>>> I should probably change the code elsewhere too, but this test >>> is unnecessary because ckpt_obj_fetch() will complain anyway. >> I don't think it will complain since I don't see anything in the read or hash >> code that checks for negative objrefs. However moving this into > > What is "this" that you want to move ? > >> ckpt_obj_fetch() would get rid of alot of code much like passing NULL into >> kfree() does, so I'll remove this test. > > ckpt_obj_fetch() won't complain about a negative value a-priori, but > the search is certain to fail. Nevertheless, I'll tighten the restart > related calls in objhash to ensure that.
I take it back: ckpt_obj_fetch() returns -EINVAL when an objref isn't found, not that the original value was invalid. Oren _______________________________________________ Containers mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/containers _______________________________________________ Devel mailing list [email protected] https://openvz.org/mailman/listinfo/devel
