On 2010年11月02日 03:15, Jiri Olsa wrote: > hi, This..
> the rcu_dereference_check is defined as > > #define rcu_dereference_check(p, c) \ > __rcu_dereference_check((p), rcu_read_lock_held() || (c), __rcu) > > so the caller does not need to specify rcu_read_lock_held() condition. > > wbr, > jirka and this should be excluded from the changelog. > > > Signed-off-by: Jiri Olsa <[email protected]> Reviewed-by: Li Zefan <[email protected]> However a nitpick: > --- > include/linux/cgroup.h | 1 - > kernel/cgroup.c | 6 ++---- > 2 files changed, 2 insertions(+), 5 deletions(-) ... > @@ -4544,7 +4542,7 @@ unsigned short css_id(struct cgroup_subsys_state *css) > * it's unchanged until freed. > */ > cssid = rcu_dereference_check(css->id, > - rcu_read_lock_held() || atomic_read(&css->refcnt)); > + atomic_read(&css->refcnt)); Now the 2 lines can be made into one line and still fit into 80 chars. > > if (cssid) > return cssid->id; > @@ -4557,7 +4555,7 @@ unsigned short css_depth(struct cgroup_subsys_state > *css) > struct css_id *cssid; > > cssid = rcu_dereference_check(css->id, > - rcu_read_lock_held() || atomic_read(&css->refcnt)); > + atomic_read(&css->refcnt)); dito > > if (cssid) > return cssid->depth; _______________________________________________ Containers mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/containers _______________________________________________ Devel mailing list [email protected] https://openvz.org/mailman/listinfo/devel
