Kir, In this patchset, I hope to be addressing all your concerns. It is a bit massive code, so if is there still anything that you would me to change, don't shy away. I will go back to it ASAP.
That said, I am incorporating your comments on the previous PATCH 4 (now 1), and adding another one, that also passes cmd_p to open. This is being sent as an incremental patch since you said you have already merged up to PATCH 3 (I still don't see that in git). But if you haven't feel free to fold it. With this patch, we are fully able to get rid of the default value during create, and yet test for userns presence very early during creation time. I think this very much clarifies our handling of the command line option. The documentation is also changed as you requested, for consistency. Glauber Costa (7): user namespace support for upstream containers add user mismatch test Also pass cmd_p pointer to container open allow local uid and gid to be specified at container creation modify tar extraction to account for user namespace automatically add bridge venet0 when needed allow for distro-specific fix ups at creation time. etc/dists/redhat.conf | 1 + etc/dists/scripts/fixups.sh | 43 ++++++ include/dist.h | 2 + include/env.h | 12 +- include/res.h | 6 + include/types.h | 1 + man/vzctl.8.in | 17 +++ scripts/vps-create.in | 14 ++ scripts/vps-functions.in | 7 + src/lib/Makefile.am | 3 + src/lib/chown_preload.c | 93 ++++++++++++ src/lib/create.c | 25 +++- src/lib/dist.c | 10 +- src/lib/env.c | 33 ++++- src/lib/exec.c | 2 +- src/lib/hooks_ct.c | 338 ++++++++++++++++++++++++++++++++++++++++++-- src/lib/hooks_vz.c | 2 +- src/vzctl-actions.c | 4 +- src/vzctl.c | 1 + vzctl.spec | 2 +- 20 files changed, 583 insertions(+), 33 deletions(-) create mode 100755 etc/dists/scripts/fixups.sh create mode 100644 src/lib/chown_preload.c -- 1.7.11.7 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel