On Wed, Jul 29, 2015 at 12:43:36PM +0300, Vladimir Davydov wrote: > There is a problem with this patch set - it makes ptmx device > system-wide while its class, tty_class, is still virtualized. Since it's > now system-wide, we have to add its sysfs entry to > ve.default_sysfs_permissions, but since its class is virtualized, we > won't be able to do it (see sysfs_perms_set -> sysfs_find_dirent). > > As a result, if the container relies on sysfs while creating devnodes, > it will not find ptmx and therefore fallback to legacy ptys, which we > are going to drop. We either need a follow-up quick fix for this issue, > or we could probably drop tty_class virtualization altogether (not sure > if the latter is possible, because we still need vzconsole, which > depends on it AFAICS). > > Anyway, please postpone this patch set. Since "[PATCH rh7 0/6] zap > sb->s_ns + fix memleak in binfmt_misc" won't work w/o it, postpone it > too.
Good point. I'm reworking vzt console code now (I've fetched this series into local queue) gimme some time to figure out if we can live without tty-class virtualized... _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel
