On Mon, Nov 23, 2015 at 04:04:22PM +0300, Vladimir Davydov wrote:
> > +#ifdef CONFIG_VE
> > +           if (tty_hung_up_p(file) ||
> > +               (tty->link && !tty->link->count &&
> > +                !(test_bit(TTY_PINNED_BY_OTHER, &tty->link->flags)))) {
> > +#else
> >             if (tty_hung_up_p(file) || (tty->link && !tty->link->count)) {
> > +#endif
> 
> I wouldn't surround TTY_PINNED_BY_OTHER with CONFIG_VE here and there,
> but I see that you do it so as to track our changes easier. Well, I
> think, git log suits the purpose better, but it isn't worth arguing
> upon, so
> 
> Reviewed-by: Vladimir Davydov <[email protected]>

Thank you a lot!

p.s. I rather preser keep config option in code than walking over git logs :)
_______________________________________________
Devel mailing list
[email protected]
https://lists.openvz.org/mailman/listinfo/devel

Reply via email to