On 06/23/2016 10:25 AM, Dmitry Monakhov wrote:
Currently noone tag preqs with such bit but let it be here for simmetry

I hate dead code (things that impossible to verify by any test). Can we add this "symmetry" check later, along with a patch for kaio setting this bit? (i.e.: kaio doesn't set it; ergo it must not check it)


Signed-off-by: Dmitry Monakhov <[email protected]>
---
  drivers/block/ploop/io_kaio.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/block/ploop/io_kaio.c b/drivers/block/ploop/io_kaio.c
index bee2cee..5341fd5 100644
--- a/drivers/block/ploop/io_kaio.c
+++ b/drivers/block/ploop/io_kaio.c
@@ -73,6 +73,7 @@ static void kaio_complete_io_state(struct ploop_request * 
preq)
/* Convert requested fua to fsync */
        if (test_and_clear_bit(PLOOP_REQ_FORCE_FUA, &preq->state) ||
+           test_and_clear_bit(PLOOP_REQ_DEL_FLUSH, &preq->state) ||
            test_and_clear_bit(PLOOP_REQ_KAIO_FSYNC, &preq->state))
                post_fsync = 1;

_______________________________________________
Devel mailing list
[email protected]
https://lists.openvz.org/mailman/listinfo/devel

Reply via email to