> From: Yu Kuai <[email protected]> > > Tightening the throttle activation check in blk_throtl_activated() to > require both q->td presence and policy bit set introduced a memory leak > during disk release: > > blkg_destroy_all() clears the policy bit first during queue deactivation, > causing subsequent blk_throtl_exit() to skip throtl_data cleanup when > blk_throtl_activated() fails policy check. > > Idealy we should avoid modifying blk_throtl_exit() activation check because > it's intuitive that blk-throtl start from blk_throtl_init() and end in > blk_throtl_exit(). However, call blk_throtl_exit() before > blkg_destroy_all() will make a long term deadlock problem easier to > trigger[1], hence fix this problem by checking if q->td is NULL from > [ ... ] > > https://virtuozzo.atlassian.net/browse/VSTOR-152993 > Feature: fix ms/block > > Signed-off-by: Denis V. Lunev <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review ยท https://sashiko.vzint.dev/#/patchset/[email protected]?part=2 _______________________________________________ Devel mailing list [email protected] https://lists.openvz.org/mailman/listinfo/devel
