On 11/3/26 19:36, [email protected] wrote:
Thank you for your contribution! Sashiko AI review found 1 potential issue(s)
to consider:
- [Low] selftests: commit message has non-upstream Jira URL and Feature: trailer
--
commit 14e4827eb4828e3a2b673ab078fcd08a723d8929
Author: Eva Kurchatova <[email protected]>
selftests: forwarding: flush neighbours in the locked port MAB test
This commit adds an "ip neigh flush dev $h1" after the FDB entry is
replaced in locked_port_mab(). With the flush, the following ping starts
a fresh neighbour resolution instead of reusing an entry that timed out
while the port was locked.
selftests: forwarding: flush neighbours in the locked port MAB test
locked_port_mab starts with the neighbour entry for 192.0.2.2 that
[ ... ]
Fixes: 4a331d346996 ("selftests: forwarding: Add MAC Authentication Bypass (MAB)
test cases")
https://virtuozzo.atlassian.net/browse/VSTOR-153057
Feature: fix selftests
Signed-off-by: Eva Kurchatova <[email protected]>
[Severity: Low]
This isn't a bug in the code, but the commit message has two lines that
don't belong in an upstream changelog:
https://virtuozzo.atlassian.net/browse/VSTOR-153057
Feature: fix selftests
The first line points to a private issue tracker that other readers can't
open. The second is a "Feature:" trailer, which isn't a recognized kernel
trailer.
Could both lines be dropped if this patch is sent to mainline or netdev?
diff --git a/tools/testing/selftests/net/forwarding/bridge_locked_port.sh
b/tools/testing/selftests/net/forwarding/bridge_locked_port.sh
--- a/tools/testing/selftests/net/forwarding/bridge_locked_port.sh
+++ b/tools/testing/selftests/net/forwarding/bridge_locked_port.sh
[ ... ]
@@ -201,6 +201,7 @@ locked_port_mab()
check_err $? "Locked FDB entry not created"
bridge fdb replace `mac_get $h1` dev $swp1 master static
+ ip neigh flush dev $h1
ping_do $h1 192.0.2.2
check_err $? "Ping did not work after replacing FDB entry"
Indeed so, this is not an upstream mailing list either. The trailers are
intentional requirement.
_______________________________________________
Devel mailing list
[email protected]
https://lists.openvz.org/mailman/listinfo/devel
