+ /* Retry R1/R2 writeback failed with ENOSPC once, then give up */
Item 3 of the cover letter reply: say "up to two attempts", and that
MD_DIRTY is dropped at submit.
Why: a page that failed with ENOSPC before the flush is redirtied. Pass
0 fires the timer and writes it, and since md_wb_no_retry is still
false there, a second failure redirties it again. Pass 1 writes it once
more. MD_DIRTY is cleared in submit_metadata_writeback(), before the
write, not by its failure.
Item 4 of the cover letter reply: mention the leak per resubmission.
Why: with this patch a request whose L2 write fails with ENOSPC ends
with BLK_STS_NOSPC and is resubmitted after ENOSPC_TIMEOUT_JI. The L2
entry was reverted to 0, so the resubmitted request allocates a new
data cluster, and patch 8 keeps the old one. One sentence in the
message is enough; it lasts only as long as the host is out of space.
Agreed, R1/R2 go out after L1/L2 here, so the v11 wording was wrong.
v12 patch 9 now says one cluster leaks per failed L1/L2 write of a
request.
_______________________________________________
Devel mailing list
[email protected]
https://lists.openvz.org/mailman/listinfo/devel
