> From: Denis V. Lunev <[email protected]> > > Commit a1049e020cdf ("ve/net/gre: Disable ERSPAN support in ip_gre > module") compiled erspan_net_ops out under CONFIG_VE but left the ERSPAN > receive and ICMP error paths in place. erspan_net_id is then never > assigned and stays 0, and net_generic(net, 0) does not return NULL: it > returns the length word of struct net_generic, which ptr[0] overlays. > ip_tunnel_lookup() passes its NULL check and reads itn->tunnels[] in > the first page. Once ip_gre is loaded, any GRE packet with protocol > ETH_P_ERSPAN or ETH_P_ERSPAN2 delivered to the node panics it in > softirq, and so does an ICMP error quoting such a header. The packet > can come from the network or from container root with a raw socket. > > Return a NULL itn for ERSPAN under CONFIG_VE, so both paths miss the > lookup and handle the packet as one for a tunnel that does not exist. > > Fixes: a1049e020cdf ("ve/net/gre: Disable ERSPAN support in ip_gre module") > > https://virtuozzo.atlassian.net/browse/VSTOR-154362 > Feature: net: disable ERSPAN support in ip_gre module > Signed-off-by: Denis V. Lunev <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review ยท https://sashiko.vzint.dev/#/patchset/[email protected]?part=1 _______________________________________________ Devel mailing list [email protected] https://lists.openvz.org/mailman/listinfo/devel
