> From: Denis V. Lunev <[email protected]> > > sit_init_net() frees the sit_net of a netns whose VE lacks > VE_FEATURE_SIT. Only the fallback sit0 is netns_immutable, so the host > can move any other sit tunnel into such a container with > "ip link set s6 netns <CT>". ipip6_dellink() looks sitn up in > dev_net(dev) and reads sitn->fb_tunnel_dev, so the node panics on a > NULL pointer dereference when container root deletes the tunnel, when > the container stops and cleanup_net() deletes it, or when sit is > unloaded. > > Take sitn from t->net, the netns the tunnel was created in and is > hashed in, as changelink, uninit and the ioctl handlers already do. The > fallback device cannot leave its netns, so the fb_tunnel_dev comparison > keeps its meaning. > > Fixes: 5aed376d130d ("net: Make sit feature optional") > > https://virtuozzo.atlassian.net/browse/VSTOR-154347 > Feature: ve: per-CT features management > Signed-off-by: Denis V. Lunev <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review ยท https://sashiko.vzint.dev/#/patchset/[email protected]?part=2 _______________________________________________ Devel mailing list [email protected] https://lists.openvz.org/mailman/listinfo/devel
