> From: David Carlier <[email protected]> > > Commit 340f0c7067a9 ("eventfs: Update all the eventfs_inodes from the > events descriptor") had eventfs_set_attrs() recurse through ei->children > on remount. The walk only holds the rcu_read_lock() taken by > tracefs_apply_options() over tracefs_inodes, which is wrong: > > - list_for_each_entry over ei->children races with the list_del_rcu() > in eventfs_remove_rec() -- LIST_POISON1 deref, same shape as > d2603279c7d6. > - eventfs_inodes are freed via call_srcu(&eventfs_srcu, ...). > rcu_read_lock() does not extend an SRCU grace period, so ti->private > can be reclaimed under the walk. > - The writes to ei->attr race with eventfs_set_attr(), which holds > eventfs_mutex. > [ ... ] > > https://virtuozzo.atlassian.net/browse/VSTOR-154529 > Feature: fix ms/tracefs > > Signed-off-by: Eva Kurchatova <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review ยท https://sashiko.vzint.dev/#/patchset/[email protected]?part=1 _______________________________________________ Devel mailing list [email protected] https://lists.openvz.org/mailman/listinfo/devel
