> The inactive variants of test_numa_migrate report their pages populated
> before they madvise(MADV_COLD) them. The parent starts the migration as
> soon as 85% of the pages are inactive on the source node, while the
> rest are still being deactivated. memory.numa_migrate takes the size of
> each LRU list as its scan budget when it gets to the list, so the pages
> that become inactive later are not scanned, and up to the 15% that
> verify_stats() tolerates can stay behind. The slower a kernel
> deactivates the pages, the more often the test fails, which made
> inactive_disk_file fail often on coverage kernels.
> 
> Call madvise(MADV_COLD) before reporting the pages populated.
> 
> Fixes: 3842964f4497 ("selftests: cgroup: test numa migration of lruvecs")
> https://virtuozzo.atlassian.net/browse/VSTOR-154520
> Feature: fix selftests
> 
> Signed-off-by: Eva Kurchatova <[email protected]>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review ยท 
https://sashiko.vzint.dev/#/patchset/[email protected]?part=2


_______________________________________________
Devel mailing list
[email protected]
https://lists.openvz.org/mailman/listinfo/devel

Reply via email to