Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] vhost: Fixes tag cites commit not in this branch's history --
commit bbef82128842543692a63a5ea711dc103da3faf0 Author: Alexander Ivanov <[email protected]> drivers/vhost: fix a use-after-free of VHOST_SET_NWORKERS workers The patch attaches the workers created by VHOST_SET_NWORKERS through __vhost_vq_attach_worker() instead of storing them in vq->worker directly. It also skips a source vq whose worker was killed, and rejects VHOST_SET_NWORKERS on devices that do not use workers. > drivers/vhost: fix a use-after-free of VHOST_SET_NWORKERS workers > > vhost_set_workers() and vhost_propagate_workers() store workers into > vq->worker directly, bypassing __vhost_vq_attach_worker(). The workers > they install keep attachment_cnt at 0, and the default worker keeps > counting every vq. VHOST_FREE_WORKER then destroys a worker a virtqueue > still points at, and the next vhost_vq_work_queue() on that vq is a > use-after-free. VHOST_ATTACH_VRING_WORKER on such a vq drives > attachment_cnt of its worker to -1. vhost-scsi already exposes both > interfaces to the device owner. > > Attach the workers with __vhost_vq_attach_worker(), so VHOST_FREE_WORKER > fails with -EBUSY while a vq uses the worker and both interfaces can > coexist until userspace moves to the worker ioctls. Userspace issues > VHOST_SET_NWORKERS before VHOST_SET_VRING_KICK, so the attach takes the > path without synchronize_rcu() and VM startup is not slowed down. > > The attach dereferences the worker, so skip a source vq whose worker > was killed, and reject VHOST_SET_NWORKERS on devices that do not use > workers. On vhost-vdpa every vq->worker is NULL, and the workers > vhost_set_workers() created there were never freed. > > https://virtuozzo.atlassian.net/browse/VSTOR-107537 > Fixes: 1491588e71da ("drivers/vhost: add ioctl to increase the number of > workers") > Feature: vhost-blk: in-kernel accelerator for virtio-blk guests > > Signed-off-by: Alexander Ivanov <[email protected]> [Severity: Low] Is the Fixes: tag pointing at the right commit? 1491588e71da is not an ancestor of this branch. The commit with the same subject that is in this branch's history is 705a4b3eefde ("drivers/vhost: add ioctl to increase the number of workers"). It added vhost_set_workers(), vhost_propagate_workers() and the VHOST_SET_NWORKERS case, and it is where the direct vq->worker stores came from. Should the tag name that commit instead, so backport tooling can resolve it on this branch? -- Sashiko AI review ยท https://sashiko.vzint.dev/#/patchset/[email protected]?part=1 _______________________________________________ Devel mailing list [email protected] https://lists.openvz.org/mailman/listinfo/devel
