Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dm-qcow2: bug-fix commit lacks a Fixes: trailer
--

commit 50d27ce56be53596fa9d5de781a9cec9b705d815
Author: Alexander Ivanov <[email protected]>

> drivers/md/dm-qcow2: set header_length to 72 for v2 images
>
> qcow2_check_convert_hdr() returns for a v2 image before it fills in
> hdr->header_length, so the field stays 0 from kzalloc().
> qcow2_parse_header() uses header_length as the start of header
> extensions and so parses them from offset 0 of the image, i.e. from
> the header itself, instead of from offset 72 right after the v2 header.
>
> Set header_length to the size of the v2 header before the version
> check, as qemu does. v3 images overwrite it from the raw header.
>
> https://virtuozzo.atlassian.net/browse/VSTOR-152394
> Feature: dm-qcow2: block device over QCOW2 files driver
>
> Signed-off-by: Alexander Ivanov <[email protected]>

[Severity: Low]
This fixes a bug that has been there since the driver was introduced: the
early return for v2 images has always left header_length at 0. Should this
include:

  Fixes: 2a728299abdb ("dm-qcow2: Introduce driver to create block devices over 
QCOW2 files")

-- 
Sashiko AI review ยท 
https://sashiko.vzint.dev/#/patchset/[email protected]?part=1

_______________________________________________
Devel mailing list
[email protected]
https://lists.openvz.org/mailman/listinfo/devel

Reply via email to