> From: Paolo Abeni <[email protected]>
> 
> The subflow status bitfield is protected by the subflow socket lock,
> with one notable exception: the `close_event_done` bit is actually under
> the msk socket lock protection.
> 
> As reported by Clashiko [1], flipping the latter bit may corrupt other
> entries in the same bitfield.
> 
> Move the `close_event_done` outside the bitfield, in a 32bit hole.
> 
> Link: 
> https://lore.kernel.org/[email protected]
> Fixes: d82809b6c5f2 ("mptcp: avoid duplicated SUB_CLOSED events")
> Cc: [email protected]
> Signed-off-by: Paolo Abeni <[email protected]>
> Reviewed-by: Matthieu Baerts (NGI0) <[email protected]>
> Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
> Link: 
> https://patch.msgid.link/20261013-net-mptcp-misc-fixes-7-3-rc8-v1-2-932c9b182...@kernel.org
> Signed-off-by: Jakub Kicinski <[email protected]>
> (cherry picked from commit 7538fa33bb2f66b8b809ff39d58308be48e197a0)
> 
> Rebase note: this tree has neither the "closing" nor the "resetting"
> subflow flag, nor lent_mem_frag, so __unused grows from 9 to 10 and
> close_event_done goes after fully_established.
> 
> https://virtuozzo.atlassian.net/browse/VSTOR-154927
> Feature: fix ms/net
> 
> Signed-off-by: Eva Kurchatova <[email protected]>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review ยท 
https://sashiko.vzint.dev/#/patchset/[email protected]?part=2


_______________________________________________
Devel mailing list
[email protected]
https://lists.openvz.org/mailman/listinfo/devel

Reply via email to