Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] dm-qcow2: commit message says enospc policy holds whatever the error --
commit 142ca81f38b1cbdf25eca9913dfb6764e3cbe6b1 Author: Alexander Ivanov <[email protected]> drivers/md/dm-qcow2: add the error_policy table argument This commit adds an optional error_policy=<read>,<write> table argument to dm-qcow2. Each policy is report, enospc or stop, and it controls which failed requests are held for resubmission instead of being completed with an error. > Requests failed under > the enospc or stop policy are held, reported and resubmitted like > ENOSPC writes are now, whatever the error. [Severity: Low] Is this sentence accurate for the enospc policy? In qcow2_try_hold_error(), the check (policy == QCOW2_ERROR_ENOSPC && bi_status != BLK_STS_NOSPC) returns false. So under enospc only BLK_STS_NOSPC failures are held. Only the stop policy holds any error, apart from BLK_STS_NOTSUPP. The sentence also contradicts the commit message's own earlier text, which says enospc applies "for ENOSPC only". -- Sashiko AI review ยท https://sashiko.vzint.dev/#/patchset/[email protected]?part=7 _______________________________________________ Devel mailing list [email protected] https://lists.openvz.org/mailman/listinfo/devel
