Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ve: commit message omits removal of DEAD transition in
  ve_destroy()
--

commit 23cbc0a68783a5b04322e1e051abf52807d3e18c
Author: Vladimir Riabchun <[email protected]>

> ve: Remove STOPPED state
>
> We don't need extra STOPPED state. It makes us feel that CT
> could be started again from it, but it is actually not true.
>
> Separate STOPPED state doesn't bring any value. Drop it and
> transition VE to DEAD state directly on the stop.
>
> https://virtuozzo.atlassian.net/browse/VSTOR-142405
> Reviewed-by: Pavel Tikhomirov <[email protected]>
> Signed-off-by: Vladimir Riabchun <[email protected]>

[Severity: Low]
This isn't a bug, but the changelog leaves out one change the diff makes. The 
ve_set_state(ve, VE_STATE_DEAD) call in ve_destroy() is deleted, and the 
message never mentions it.

The removal looks right. ve_exit_ns() and the ve_start_container() error path 
now set DEAD, so keeping the call would hit the "already DEAD" warning in 
ve_set_state(). The old call also stored to the object that kmem_cache_free() 
frees on the next line.

One side effect is worth stating. A VE that is destroyed while still in 
STARTING no longer passes through DEAD. Could the message list this change and 
explain why it is safe?

-- 
Sashiko AI review ยท 
https://sashiko.vzint.dev/#/patchset/[email protected]?part=1

_______________________________________________
Devel mailing list
[email protected]
https://lists.openvz.org/mailman/listinfo/devel

Reply via email to