A Container can freeze a file system it mounted itself, since
ioctl_fsfreeze() and ioctl_fsthaw() only check CAP_SYS_ADMIN in
s_user_ns. That is a bad thing to allow:
* Processes on top of a frozen file system hang in the kernel, so
CRIU can neither ptrace attach nor freeze them and the checkpoint
fails.
* CRIU does not dump the frozen state anyway, so after restore the
file system comes back thawed although it was frozen on the source.
Nothing vital inside a Container is known to need it, and most file
systems a Container sees are not freezable at all. So keep the
existing check and return EPERM for FIFREEZE and FITHAW when called
from a Container.
https://virtuozzo.atlassian.net/browse/VSTOR-155592
Feature: ve: allow various syscalls in CT root userns
Suggested-by: Pavel Tikhomirov <[email protected]>
Signed-off-by: Vasileios Almpanis <[email protected]>
---
fs/ioctl.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/fs/ioctl.c b/fs/ioctl.c
index d8b2c630cb3e..1927a10ad8a0 100644
--- a/fs/ioctl.c
+++ b/fs/ioctl.c
@@ -22,6 +22,7 @@
#include <linux/mount.h>
#include <linux/fscrypt.h>
#include <linux/fileattr.h>
+#include <linux/ve.h>
#include "internal.h"
@@ -394,7 +395,8 @@ static int ioctl_fsfreeze(struct file *filp)
{
struct super_block *sb = file_inode(filp)->i_sb;
- if (!ns_capable(sb->s_user_ns, CAP_SYS_ADMIN))
+ if (!ve_is_super(get_exec_env()) ||
+ !ns_capable(sb->s_user_ns, CAP_SYS_ADMIN))
return -EPERM;
/* If filesystem doesn't support freeze feature, return. */
@@ -411,7 +413,8 @@ static int ioctl_fsthaw(struct file *filp)
{
struct super_block *sb = file_inode(filp)->i_sb;
- if (!ns_capable(sb->s_user_ns, CAP_SYS_ADMIN))
+ if (!ve_is_super(get_exec_env()) ||
+ !ns_capable(sb->s_user_ns, CAP_SYS_ADMIN))
return -EPERM;
/* Thaw */
---
base-commit: a656d0a24ddd1939d7deea2f7450873e662c828e
change-id: 20261117-ct-fsfreeze-7e16ba48a545
--
Best regards, Vasileios Almpanis
Software Developer, Virtuozzo.
_______________________________________________
Devel mailing list
[email protected]
https://lists.openvz.org/mailman/listinfo/devel