Applying with these fixes on my side:
- message: a list of what changes in the logs, after the first
  paragraph
- "Affects: #ASUP-3693" -> the tracker URL; "Feature: vStorage" added

On Tue, 17 Nov 2026 21:25:58 +0800, Alexey Kuznetsov wrote:
> These fixes were done in user space long ago,
> but we forgot to do them in kernel: print correctly
> formatted client ID and show correct origin of
> error.

The message did not say what changes in the logs. I added:

  - NODE_FMT prints an id with PCS_NODE_ALT_MASK set (the kernel
    client, the origin of every XID) as "K<id>" instead of 2^63 plus
    the id.
  - The IO error line in cs_response_done() adds the id of the CS the
    request was sent to and the chunk uid, and drops the ireq pointer.
  - The cs_stats id column prints the raw id itself, since NODE_ARGS
    now expands to two arguments.

The code is fine. Sashiko's remark on the (unsigned long) casts does
not apply: vz10 builds no 32-bit kernels.

Thanks.

-- 
Konstantin Khorenko,
Virtuozzo Linux Kernel Team

_______________________________________________
Devel mailing list
[email protected]
https://lists.openvz.org/mailman/listinfo/devel

Reply via email to