Hi, Unfortunately, we just found
https://bugzilla.redhat.com/show_bug.cgi?id=1098539 This looks like an engine bug, however. Can someone please check and help with a fix? Thanks, ----- Original Message ----- > From: "Dan Kenigsberg" <[email protected]> > To: "Francesco Romani" <[email protected]> > Cc: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)" <[email protected]>, "Gilad > Chaplik([email protected])" > <[email protected]>, "Doron Fediuck ([email protected])" > <[email protected]>, "Chuan Liao (Jason Liao, > HPservers-Core-OE-PSC)" <[email protected]>, [email protected], "Shang-Chun > Liang (David Liang, > HPservers-Core-OE-PSC)" <[email protected]> > Sent: Thursday, May 8, 2014 4:02:44 PM > Subject: Re: Vdsm patches need review and merge > > On Thu, May 08, 2014 at 08:48:52AM -0400, Francesco Romani wrote: > > > > ----- Original Message ----- > > > From: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)" <[email protected]> > > > To: "Dan Kenigsberg ([email protected])" <[email protected]>, "Francesco > > > Romani" <[email protected]> > > > Cc: "Gilad Chaplik <[email protected]> ([email protected])" > > > <[email protected]>, "Doron Fediuck > > > ([email protected])" <[email protected]>, "Chuan Liao (Jason Liao, > > > HPservers-Core-OE-PSC)" <[email protected]>, > > > [email protected], "Shang-Chun Liang (David Liang, HPservers-Core-OE-PSC)" > > > <[email protected]> > > > Sent: Thursday, May 8, 2014 2:33:14 PM > > > Subject: RE: Vdsm patches need review and merge > > > > > > Hi Dan/Francesco, > > > > > > Could you help to review and merge these patches: > > > http://gerrit.ovirt.org/#/c/27515/ (This patch is needed by 26876 since > > > some > > > comments in that patch need to modify caps module) > > > http://gerrit.ovirt.org/#/c/26876/ > > > http://gerrit.ovirt.org/#/c/27403/ > > > > > > I didn't modify some comments in 26876 since I think they are related > > > with > > > codes refactor and literal syntax. I will submit a separate patch to > > > modify > > > these kinds of comments of numa feature altogether later. Could you > > > please > > > now focus on the functionality since we need to merge these patches ASAP? > > > > http://gerrit.ovirt.org/#/c/27403 > > I'm OK with it (gave +1) > > > > http://gerrit.ovirt.org/#/c/26876 > > I don't have objections and I don't see blockers for the functionality. > > I'm not 100% happy with the implementation, but the existing one is on par > > with most of code, and if we're in hurry, I guess refinements can wait. > > > > http://gerrit.ovirt.org/#/c/27515 > > good enough for the same reasons above (gave +1) > > Puritans would suggest to squash this into 26876, or fix the commit > message - prior to 26876 nothing uses these private methods. But never > mind, taken. > -- Francesco Romani RedHat Engineering Virtualization R & D Phone: 8261328 IRC: fromani _______________________________________________ Devel mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/devel
