----- Original Message ----- > From: "Gilad Chaplik" <[email protected]> > To: "Lior Vernia" <[email protected]> > Cc: "Greg Sheremeta" <[email protected]>, [email protected], "Alexander Wels" > <[email protected]>, "Vojtech Szocs" > <[email protected]>, "Einav Cohen" <[email protected]>, "Alona Kaplan" > <[email protected]>, "Tomas Jelinek" > <[email protected]>, "Juan Hernandez" <[email protected]> > Sent: Thursday, May 29, 2014 2:28:59 PM > Subject: Re: fixing whitespace in ui.xml files > > ----- Original Message ----- > > From: "Lior Vernia" <[email protected]> > > To: "Greg Sheremeta" <[email protected]> > > Cc: [email protected], "Alexander Wels" <[email protected]>, "Vojtech Szocs" > > <[email protected]>, "Einav Cohen" > > <[email protected]>, "Alona Kaplan" <[email protected]>, "Gilad Chaplik" > > <[email protected]>, "Tomas Jelinek" > > <[email protected]> > > Sent: Thursday, May 29, 2014 2:56:29 PM > > Subject: Re: fixing whitespace in ui.xml files > > > > Sounds good to me, I think the only reason they're not formatted is that > > the Java formatter by default ignores them. > > > > On 29/05/14 14:51, Greg Sheremeta wrote: > > > Hi, > > > > > > Can we agree to use the same .java file space standards in our gwt ui.xml > > > files? Specifically: spaces only, no tabs, 4 spaces indent, no trailing > > > whitespace. > > [adding Juan] > I agree on same formatting as api.xsd.
Hm, api.xsd seems to use 2 spaces per "tab", without a space before "/>" part. While none of these are that big of a deal, we should stay consistent with accompanying (Java) code, i.e. have single whitespace policy for both source and XML files. (The space before "/>" part is a courtesy to older XML/XHTML parsers and is not really important IMHO.) > > > > > > > I have my Eclipse set to fix these things (with the anyedit plugin), and > > > the ui.xml files always have tabs and trailing space in them. > > > > > > If we agree, I volunteer to fix them all and post a patch. I think we can > > > also set gerrit to point these out. > > > > > > Thanks, > > > Greg > > > > > > Greg Sheremeta > > > Red Hat, Inc. > > > Sr. Software Engineer, RHEV > > > Cell: 919-807-1086 > > > [email protected] > > > > > > _______________________________________________ Devel mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/devel
