On 07/22/2014 02:54 PM, Piotr Kliczewski wrote:
On Tue, Jul 22, 2014 at 2:04 PM, Vinzenz Feenstra <[email protected]> wrote:
On 07/22/2014 02:00 PM, Francesco Romani wrote:
----- Original Message -----
From: "Vinzenz Feenstra" <[email protected]>
To: [email protected]
Sent: Tuesday, July 22, 2014 11:29:40 AM
Subject: Re: [ovirt-devel] "Host.queryVms": A proposal for new a VDSM API
verb
On 07/14/2014 04:05 PM, Vinzenz Feenstra wrote:
Hi,
Since this mail did not receive enough attention I am bumping it again.
For this proposal exists currently a draft patch
http://gerrit.ovirt.org/#/c/28819/
The patch is not final since the query function should not require to
update all the data
on every call. (This should be done directly by data modifying code.
However that would be implemented by follow up patches)
The trackable.py implementation also can be easily extended in future
for enabling push notifications to the engine once
we switched to the new communication. This could be done by subscribing
to certain keys in the TrackableMapping instance.
(Not implemented yet)
Nice! Both nice to have now and on top of json/push notifications
tomorrow.
I just had a quick look to the changes to vm.py and to the interface
and looks nice as well.
[...]
I have executed some tests and in those tested scenarios the new Verb
can result in an improvement of 75%-90% of data transferred and average
response body size depending on the scenario and usage.
The test results can be found here:
http://www.ovirt.org/Feature/VDSM_VM_Query_API/Measurements#Results
(An explanation of the tested methods is on the top of the page and a
description of the scenario in each section)
Nice graphs :)
Silly comment: having units in 'bytes' on the X-axis makes the numbers
somehow
hard to parse (to me). I suggest you to convert them to KiB for better
readability.
The savings look really nice.
The table below shows it in MiB in a separate column
Bests,
API looks good but I have small comment to json schema. Vdsm is
currently versioned 4.16 not
4.15 so please update Since for each schema change.
I'll do with the next rebase of the patch, thanks for pointing it out. :-)
--
Regards,
Vinzenz Feenstra | Senior Software Engineer
RedHat Engineering Virtualization R & D
Phone: +420 532 294 625
IRC: vfeenstr or evilissimo
Better technology. Faster innovation. Powered by community collaboration.
See how it works at redhat.com
_______________________________________________
Devel mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/devel
--
Regards,
Vinzenz Feenstra | Senior Software Engineer
RedHat Engineering Virtualization R & D
Phone: +420 532 294 625
IRC: vfeenstr or evilissimo
Better technology. Faster innovation. Powered by community collaboration.
See how it works at redhat.com
_______________________________________________
Devel mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/devel
