On 12/09, Oved Ourfali wrote:
> 
> 
> ----- Original Message -----
> > From: "Sven Kieske" <s.kie...@mittwald.de>
> > To: devel@ovirt.org
> > Sent: Tuesday, December 9, 2014 3:21:43 PM
> > Subject: Re: [ovirt-devel] Creating a new gerrit flag
> > 
> > 
> > 
> > On 09/12/14 13:47, Oved Ourfali wrote:
> > > safe up to 95% or so.
> > 
> > You just made up that number.
> > I don't really understand why you would want
> > to downgrade your code quality by circumventing tests.
> > 
> > Maybe someone can elaborate on this a bit?
> > 
> 
> It doesn't downgrade the code quality.
> It is just a way to ensure developers can both merge changes, and do it as 
> safely as possible without relying on post-submit tools.
> The number is indeed invented... as I don't have real statistics, but it 
> comes to say that it would be safe most of the time.
> After the patch is merged, if CI will fail, it is the responsibility of the 
> developer to check that out and fix that.

This thread was started to avoid getting to that point, as getting a
failed patch inside the code means breaking all the other tests that
run on top of it and that blocks all the development, not only that
specific patch.

> 
> > --
> > Mit freundlichen Grüßen / Regards
> > 
> > Sven Kieske
> > 
> > Systemadministrator
> > Mittwald CM Service GmbH & Co. KG
> > Königsberger Straße 6
> > 32339 Espelkamp
> > T: +49-5772-293-100
> > F: +49-5772-293-333
> > https://www.mittwald.de
> > Geschäftsführer: Robert Meyer
> > St.Nr.: 331/5721/1033, USt-IdNr.: DE814773217, HRA 6640, AG Bad Oeynhausen
> > Komplementärin: Robert Meyer Verwaltungs GmbH, HRB 13260, AG Bad Oeynhausen
> > _______________________________________________
> > Devel mailing list
> > Devel@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/devel
> _______________________________________________
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel

-- 
David Caro

Red Hat S.L.
Continuous Integration Engineer - EMEA ENG Virtualization R&D

Tel.: +420 532 294 605
Email: dc...@redhat.com
Web: www.redhat.com
RHT Global #: 82-62605

Attachment: pgpQyB4vEpSrT.pgp
Description: PGP signature

_______________________________________________
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Reply via email to