On 29-04-2015 7:46, Francesco Romani wrote:
----- Original Message -----
From: "Christopher Pereira" <[email protected]>
To: "Nir Soffer" <[email protected]>
Cc: [email protected]
Sent: Wednesday, April 29, 2015 12:33:01 PM
Subject: Re: [ovirt-devel] VDSM - sampling.py - remove() called without
previous add()
On 28-04-2015 17:44, Nir Soffer wrote:
In sampling.py, remove() is being called without calling add() before,
which
throws:
Fixed in master, please update:
https://gerrit.ovirt.org/40223
Hi Nir,
Still present:
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/yajsonrpc/__init__.py", line
464, in _serveRequest
res = method(**params)
File "/usr/share/vdsm/rpc/Bridge.py", line 273, in _dynamicMethod
result = fn(*methodArgs)
File "/usr/share/vdsm/API.py", line 339, in destroy
res = v.destroy()
File "/usr/share/vdsm/virt/vm.py", line 3517, in destroy
result = self.doDestroy()
File "/usr/share/vdsm/virt/vm.py", line 3535, in doDestroy
return self.releaseVm()
File "/usr/share/vdsm/virt/vm.py", line 3450, in releaseVm
<-------------------------------- Also called here
sampling.stats_cache.remove(self.id)
File "/usr/share/vdsm/virt/sampling.py", line 428, in remove
del self._vm_last_timestamp[vmid]
So you reproduced this bug with VDSM with 40223 applied (let's say, today's
master branch)?
Yes. I cloned github and am pulling patches from gerrit.
I also checked the file to confirm the patch was applied.
Which flow is this, just shutdding down a VM?
I guess the VM was down and about to start. It probably failed to start
because the MasterStorageDomain was down.
I did basic sanity check as part of verification of 40223, and didn't noticed
blatant mistakes. :\
I saw the patch eliminating the remove() call from one section, but it
was also called on another one (vm.py, line 3450).
_______________________________________________
Devel mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/devel
