Vojtech, Any ideas on a test we can add to check-patch.sh (other than building all permutations) that can help catch these ?
The original patch didn't fail on unit tests (though I can't see info since the build got deleted, we now increased the history for builds so we will be able to see it). Please let me know once the translations patch is re-submitted,I'd like to monitor it and see if CI catch any issues there. e. On Wed, May 4, 2016 at 3:30 PM, Vojtech Szocs <[email protected]> wrote: > > > ----- Original Message ----- > > From: "Vojtech Szocs" <[email protected]> > > To: "Oved Ourfali" <[email protected]> > > Cc: "devel" <[email protected]> > > Sent: Wednesday, May 4, 2016 2:24:21 PM > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken > > > > > > > > ----- Original Message ----- > > > From: "Vojtech Szocs" <[email protected]> > > > To: "Oved Ourfali" <[email protected]>, "David Caro" > > > <[email protected]> > > > Cc: "devel" <[email protected]> > > > Sent: Wednesday, May 4, 2016 2:19:09 PM > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken > > > > > > > > > > > > ----- Original Message ----- > > > > From: "Oved Ourfali" <[email protected]> > > > > To: "Vojtech Szocs" <[email protected]> > > > > Cc: "Marek Libra" <[email protected]>, "devel" <[email protected]> > > > > Sent: Wednesday, May 4, 2016 2:07:19 PM > > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken > > > > > > > > Okay. > > > > Makes sense. > > > > Thanks Vojtech - please also revert this one. > > > > > > Trying to revert master patch https://gerrit.ovirt.org/#/c/56720/ > > > gives me "500 Internal server error" -- am I missing something? > > > > > > Perhaps oVirt gerrit maintainers can advise here? (adding David) > > > > Sorry for the noise, I did it manually with git revert: > > > > https://gerrit.ovirt.org/#/c/57031/ > > > > Can someone please ack? > > Merged, this should fix the master build. > > > > > > > > > > > > > > Oved > > > > > > > > On Wed, May 4, 2016 at 3:04 PM, Vojtech Szocs <[email protected]> > wrote: > > > > > > > > > (top-posting) > > > > > > > > > > Hi, > > > > > > > > > > root cause is wrong number of message parameters (placeholders) > > > > > in translated properties files, compared to message definitions > > > > > in Java code. > > > > > > > > > > For example, UIMessages#cpuInfoLabel method has 4 parameters, > > > > > but the corresponding message in `UIMessages_de_DE.properties` > > > > > only contains 3 placeholders. > > > > > > > > > > 4.0 String Freeze is May 25 so it's still OK to modify message > > > > > definitions in Java code. > > > > > > > > > > I suggest to simply revert the offending patch: > > > > > > > > > > translations update from zanata ovirt-3.6 > > > > > https://gerrit.ovirt.org/#/c/56720/ > > > > > > > > > > and create new one which doesn't introduce conflicts. > > > > > > > > > > We have unit tests to detect these kinds of errors, this is > > > > > to ensure the build fails early on (before GWT compilation). > > > > > > > > > > I'm not sure why `check-patch` job for above mentioned patch > > > > > didn't report the problem, since UIMessagesTest should fail, > > > > > as Roman wrote below. > > > > > > > > > > Regards, > > > > > Vojtech > > > > > > > > > > > > > > > ----- Original Message ----- > > > > > > From: "Marek Libra" <[email protected]> > > > > > > To: "devel" <[email protected]> > > > > > > Sent: Wednesday, May 4, 2016 12:31:18 PM > > > > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken > > > > > > > > > > > > There are issues on other keys as well. > > > > > > I'm rebuilding for all locales locally now. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > From: "Marek Libra" <[email protected]> > > > > > > To: "devel" <[email protected]> > > > > > > Sent: Wednesday, May 4, 2016 11:29:55 AM > > > > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken > > > > > > > > > > > > The fix is here: https://gerrit.ovirt.org/#/c/57007/ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > From: "Roman Mohr" <[email protected]> > > > > > > To: "Oved Ourfali" <[email protected]> > > > > > > Cc: "devel" <[email protected]> > > > > > > Sent: Wednesday, May 4, 2016 10:27:51 AM > > > > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken > > > > > > > > > > > > > > > > > > > > > > > > On Wed, May 4, 2016 at 10:24 AM, Oved Ourfali < > [email protected] > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > Roman - did you build the langs in order to find the issue? > > > > > > > > > > > > I just ran 'mvn clean verify', so I saw it on my machine. On > gerrit > > > > > > not > > > > > all > > > > > > of my builds showed that error. > > > > > > > > > > > > Looking at > > > > > > > > > > > > > > > > > > https://gerrit.ovirt.org/#/q/status:open+project:ovirt-engine+branch:master+topic:integration > > > > > > > > > > > > two patches passed and two failed after a topic rebase. > > > > > > > > > > > > > > > > > > > > > > > > Eyal - can we monitor a list of files that i changed will result > in > > > > > > also > > > > > > building all the languages? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Wed, May 4, 2016 at 11:22 AM, Eyal Edri < [email protected] > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > right, and we can't enable lang permutation since it takes a very > > > > > > long > > > > > time > > > > > > to run. > > > > > > > > > > > > On Wed, May 4, 2016 at 11:07 AM, Tomas Jelinek < > [email protected] > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ----- Original Message ----- > > > > > > > From: "Oved Ourfali" < [email protected] > > > > > > > > To: "Tomas Jelinek" < [email protected] > > > > > > > > Cc: "Roman Mohr" < [email protected] >, "devel" < > [email protected] >, > > > > > "Scott > > > > > > > Dickerson" < [email protected] > > > > > > > > Sent: Wednesday, May 4, 2016 9:55:40 AM > > > > > > > Subject: Re: [ovirt-devel] Master ovirt-engine build broken > > > > > > > > > > > > > > I wonder, how come the CI didn't catch that? > > > > > > > > > > > > because this happens only when you compile with language > permutations > > > > > > > > > > > > > > > > > > > > On Wed, May 4, 2016 at 10:44 AM, Tomas Jelinek < > > > > > > > [email protected] > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > hmmm, > > > > > > > > regression introduced yesterday by > > > > > https://gerrit.ovirt.org/#/c/56720/ > > > > > > > > fix on the way > > > > > > > > > > > > > > > > ----- Original Message ----- > > > > > > > > > From: "Roman Mohr" < [email protected] > > > > > > > > > > To: "devel" < [email protected] > > > > > > > > > > Sent: Wednesday, May 4, 2016 9:34:53 AM > > > > > > > > > Subject: [ovirt-devel] Master ovirt-engine build broken > > > > > > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > > > > > I see failing tests regarding to missing translations (e.g. > > > > > > > > > [1]). > > > > > > > > > > > > > > > > > > [...] > > > > > > > > > > > > > > > > > > Failed tests: > > > > > > > > > doTest(org.ovirt.engine.ui.uicompat.UIMessagesTest): > > > > > > > > > cpuInfoLabel does not match the number of parameters in > > > > > > > > > UIMessages_zh_CN.properties(..) > > > > > > > > > > > > > > > > > > [...] > > > > > > > > > > > > > > > > > > Best Regards, > > > > > > > > > > > > > > > > > > Roman > > > > > > > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > > > > http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/407/console > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > > > > > Devel mailing list > > > > > > > > > [email protected] > > > > > > > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > > _______________________________________________ > > > > > > > > Devel mailing list > > > > > > > > [email protected] > > > > > > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > > Devel mailing list > > > > > > [email protected] > > > > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > Eyal Edri > > > > > > Associate Manager > > > > > > RHEV DevOps > > > > > > EMEA ENG Virtualization R&D > > > > > > Red Hat Israel > > > > > > > > > > > > phone: +972-9-7692018 > > > > > > irc: eedri (on #tlv #rhev-dev #rhev-integ) > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > > Devel mailing list > > > > > > [email protected] > > > > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > > Devel mailing list > > > > > > [email protected] > > > > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > > Devel mailing list > > > > > > [email protected] > > > > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > > Devel mailing list > > > > > > [email protected] > > > > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > _______________________________________________ > > > > > Devel mailing list > > > > > [email protected] > > > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > Devel mailing list > > > [email protected] > > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > _______________________________________________ > > Devel mailing list > > [email protected] > > http://lists.ovirt.org/mailman/listinfo/devel > > > _______________________________________________ > Devel mailing list > [email protected] > http://lists.ovirt.org/mailman/listinfo/devel > > > -- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
_______________________________________________ Devel mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/devel
