On Tue, Dec 20, 2016 at 6:55 PM, Sandro Bonazzola <[email protected]> wrote: > > > On Tue, Dec 20, 2016 at 5:55 PM, Sandro Bonazzola <[email protected]> > wrote: >> >> >> >> On Tue, Dec 20, 2016 at 5:46 PM, Nir Soffer <[email protected]> wrote: >>> >>> On Tue, Dec 20, 2016 at 6:01 PM, Martin Sivak <[email protected]> wrote: >>> > Hi, >>> > >>> > I am trying to verify my patch for VDSM and that involves make check. >>> > That command fails with: >>> > >>> > Error: cannot run tox, please install tox 2.5.0 or later >>> > >>> > But there is no such package available for my workstation it seems. I >>> > can install python-tox, but RHEL 7+EPEL only ships with version 1.4.2. >>> >>> We expect developers to install tox from pip. We documented this on >>> ovirt.org: >>> >>> easy_install pip >>> pip install tox >>> >>> We require this for long time for tox 2.1.1. >> >> >> >> python-tox-2.3.1-1.el7 is available in CentOS OpsTool SIG: >> http://cbs.centos.org/koji/buildinfo?buildID=13867 > > > and in fedora: > https://koji.fedoraproject.org/koji/packageinfo?packageID=14887 > > So, why do we need pip?
We want the recent version, I don't want to depend on distribution packages for development tools. Once we installed tox, tox installs the specific versions of nose, pytest, pep8, pyflakes and any other tools we need inside a virtual environment using pip. So we depend on pip in any case, and installing tox using pip does not introduce a new requirement. This is the best setup for developers, you don't need to install anything but tox, and you always test code with the same tools, same tools used in the CI on both jenkins and travis. Because the tools are installed in a virtual environment, you can keep different set of tools for working on other projects. Nir > >> >> >> >>> >>> >>> Nir >>> >>> > >>> > Installed Packages >>> > Name : python-tox >>> > Arch : noarch >>> > Version : 1.4.2 >>> > Release : 8.el7 >>> > Size : 258 k >>> > Repo : installed >>> > From repo : epel >>> > >>> > >>> > -- >>> > Martin Sivak >>> > SLA / oVirt >>> > _______________________________________________ >>> > Devel mailing list >>> > [email protected] >>> > http://lists.ovirt.org/mailman/listinfo/devel >>> _______________________________________________ >>> Devel mailing list >>> [email protected] >>> http://lists.ovirt.org/mailman/listinfo/devel >> >> >> >> >> -- >> Sandro Bonazzola >> Better technology. Faster innovation. Powered by community collaboration. >> See how it works at redhat.com > > > > > -- > Sandro Bonazzola > Better technology. Faster innovation. Powered by community collaboration. > See how it works at redhat.com _______________________________________________ Devel mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/devel
