It depends who will be the users of this client.. For now, this only experimental for your plays around kubernetes, not more than that..
On Sun, Jul 16, 2017 at 6:10 PM Nir Soffer <nsof...@redhat.com> wrote: > Cool! > > This needs integration tests with real vdsm, or at least a server using > vdsm > yajsonrpc code. I'm worried about incompatibilities between the go stomp > library and our own stomp implementation, not used by any other code. > > When it works, we can convert vdsm-client to go :-) > > On Sat, Jul 15, 2017 at 8:53 AM Yaniv Bronheim <ybron...@redhat.com> > wrote: > >> Great! make it official under ovirt imo . This will be totally useful >> later on with openshift integration. Im almost convinced that once ovirt >> will run in parallel to openshift or as part of openshift, we'll need to >> call vdsm api commands via modules that with high chance will be written in >> go. Give specific example won't be meaningful much because we still >> designing all this vm+containers architecture and flows. >> Thanks >> >> On Fri, Jul 14, 2017 at 4:40 PM Adam Litke <ali...@redhat.com> wrote: >> >>> On Fri, Jul 14, 2017 at 9:32 AM, Piotr Kliczewski < >>> piotr.kliczew...@gmail.com> wrote: >>> >>>> On Fri, Jul 14, 2017 at 3:14 PM, Dan Kenigsberg <dan...@redhat.com> >>>> wrote: >>>> > On Fri, Jul 14, 2017 at 3:11 PM, Piotr Kliczewski >>>> > <piotr.kliczew...@gmail.com> wrote: >>>> >> All, >>>> >> >>>> >> I pushed very simple jsonrpc go client [1] which allows to talk to >>>> >> vdsm. I had a request to create it but if there are more people >>>> >> willing to use it I am happy to maintain it. >>>> >>> >>> Awesome Piotr! Thanks for the great work. >>> >>> >>>> >> >>>> >> Please let me know if you find any issues with it or you have any >>>> >> feature requests. >>>> > >>>> > Interesting. Which use case do you see for this client? >>>> > Currently, Vdsm has very few clients: Engine, vdsm-client, mom and >>>> > hosted-engine. Too often we forget about the non-Engine ones and break >>>> > them, so I'd be happy to learn more about a 5th. >>>> >>>> Adam asked for the client for his storage related changes. I am not >>>> sure about specific use case. >>>> >>> >>> I am looking at implementing a vdsm flexvol driver for kubernetes. This >>> would allow kubernetes pods to access vdsm volumes using the native PV and >>> PVC mechanisms. >>> >>> >>>> >>>> > >>>> > Regarding >>>> https://github.com/pkliczewski/vdsm-jsonrpc-go/blob/master/example/main.go >>>> > : programming without exceptions and try-except is a pain. don't you >>>> > need to check the retval of Subscribe and disconnect on failure? >>>> >>>> By no means example is not perfect and you are correct. I will fix. >>>> >>> >>> >>> >>> -- >>> Adam Litke >>> _______________________________________________ >>> Devel mailing list >>> Devel@ovirt.org >>> http://lists.ovirt.org/mailman/listinfo/devel >> >> -- >> Yaniv Bronhaim. >> _______________________________________________ >> Devel mailing list >> Devel@ovirt.org >> http://lists.ovirt.org/mailman/listinfo/devel > > -- Yaniv Bronhaim.
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
