Thank you very much Greg for looking into this. Your suggested message makes perfect sense. I leave my translation as-is for now (I cannot edit the source text) but when it is fixed and repushed to Zanata, I will retranslate it.
Yuko On Fri, Oct 27, 2017 at 9:44 AM, Greg Sheremeta <[email protected]> wrote: > As I thought from the context of the sentence, it's being used as a > (parameterized) Message, like this: > > if (isKsmEnabled) { > recommendationsList.add(constants.highPerformancePopupRecomm > endationMsgForKsmPart1() > + clusterName > + constants.highPerformancePopup > RecommendationMsgForKsmPart2()); > } > > So the cluster name is set between those two quotes. > > The programmer is supposed to use "Messages"[1] for this, not Constants. > The message should be: > > highPerformancePopupRecommendationMsgForKsm=KERNEL SAME PAGE MERGING > (KSM): Please disable KSM by disabling it for the Cluster: "{0}". This can > be done by editing the Cluster and disabling the "Enable KSM" field. > > ^ although I'm not sure why the cluster name would be in quotes. It > doesn't need to be. It can just say Cluster X (no colon either) > > Greg > > [1] ./frontend/webadmin/modules/webadmin/src/main/resources/ > org/ovirt/engine/ui/webadmin/ApplicationMessages.properties > Example: > geoRepSlaveVolumeToolTip=Volume data from {0} of cluster {1} is > replicated to this volume. > > On Thu, Oct 26, 2017 at 7:24 PM, Yuko Katabami <[email protected]> > wrote: > >> Hello oVirt developers. >> My next question is as follows; >> >> *File: *UIConstants >> >> >> *Resource IDs: *highPerformancePopupRecommendationMsgForKsmPart1 >> >> highPerformancePopupRecommendationMsgForKsmPart2 >> >> *Strings: * >> KERNEL SAME PAGE MERGING (KSM): >> Please disable KSM by disabling it for the Cluster: " >> >> ". This can be done by editing the Cluster and disabling the "Enable KSM" >> field. >> *Question:* There is something wrong with the usage of double quotes in >> those two strings. Could I remove it from the end of the first string, and >> the beginning of the second string (as well as the period)? >> >> Thank you, >> >> Yuko >> >> _______________________________________________ >> Devel mailing list >> [email protected] >> http://lists.ovirt.org/mailman/listinfo/devel >> > > >
_______________________________________________ Devel mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/devel
