On Thu, Dec 28, 2017 at 9:45 AM Dan Kenigsberg <[email protected]> wrote:
> yes, Petr's patch was merged 4 days ago. > Great, so this is can be merged now: https://gerrit.ovirt.org/#/c/85308/ > > On Thu, Dec 28, 2017 at 12:44 AM, Nir Soffer <[email protected]> wrote: > >> Dan, any news about the network pylint errors? >> >> >> On Tue, Dec 19, 2017 at 1:42 AM Nir Soffer <[email protected]> wrote: >> >>> On Wed, Dec 13, 2017 at 9:30 AM Dan Kenigsberg <[email protected]> >>> wrote: >>> >>>> On Tue, Dec 12, 2017 at 10:16 PM, Nir Soffer <[email protected]> >>>> wrote: >>>> >>>>> On Tue, Dec 12, 2017 at 11:04 AM Irit Goihman <[email protected]> >>>>> wrote: >>>>> >>>>>> Hi, >>>>>> I pushed two patches fixing some of the issues: >>>>>> >>>>>> https://gerrit.ovirt.org/#/c/85318/ >>>>>> https://gerrit.ovirt.org/#/c/85316/ >>>>>> >>>>> >>>>> Thanks for the quick response! >>>>> >>>>> I sent this for the libvirt events, turns out the code is mostly >>>>> correct, assuming >>>>> that libvirt does not add new arguments to the callback api, but >>>>> pylint cannot >>>>> verify this. >>>>> https://gerrit.ovirt.org/#/c/85351/ >>>>> >>>>> With this we have only these errors: >>>>> >>>>> ************* Module vdsm.v2v*00:07:29.177* *E*:1368,27: *Instance of >>>>> 'closing' has no 'read' member* (*no-member*) >>>>> >>>>> >>>>> This is handled by https://gerrit.ovirt.org/#/c/85318/ >>>>> but I think we can do a better fix *without* disabling any warning, >>>>> see the comment in: >>>>> https://gerrit.ovirt.org/#/c/85318/3/lib/vdsm/v2v.py@1369 >>>>> >>>>> *00:07:29.182* ************* Module vdsm.tool.configurator*00:07:29.186* >>>>> *E*:118,12: *No value for argument 'action' in function call* >>>>> (*no-value-for-parameter*)*00:07:29.191* *E*:158,12: *No value for >>>>> argument 'action' in function call* >>>>> (*no-value-for-parameter*)*00:07:29.195* *E*:193,12: *No value for >>>>> argument 'action' in function call* >>>>> (*no-value-for-parameter*)*00:07:29.198* *E*:215,12: *No value for >>>>> argument 'action' in function call* (*no-value-for-parameter*) >>>>> >>>>> >>>>> This is handled by https://gerrit.ovirt.org/#/c/85316/ >>>>> but I don't understand the fix. The code seems fine >>>>> and the fix make it worse. >>>>> >>>>> *00:07:29.201* ************* Module >>>>> vdsm.virt.vm_migrate_hook*00:07:29.204* *E*:199, 4: *No value for >>>>> argument 'domain' in function call* >>>>> (*no-value-for-parameter*)*00:07:29.206* *E*:199, 4: *No value for >>>>> argument 'event' in function call* >>>>> (*no-value-for-parameter*)*00:07:29.208* *E*:199, 4: *No value for >>>>> argument 'phase' in function call* (*no-value-for-parameter*) >>>>> >>>>> >>>>> Francesco, can you look at these? >>>>> >>>> >>>> Actually, that's owned by network; I hope Petr can fix it on Friday. >>>> >>> >>> These are the only errors now: >>> >>> *00:05:45.790* ************* Module vdsm.virt.vm_migrate_hook*00:05:45.796* >>> *E*:199, 4: *No value for argument 'domain' in function call* >>> (*no-value-for-parameter*)*00:05:45.803* *E*:199, 4: *No value for argument >>> 'event' in function call* (*no-value-for-parameter*)*00:05:45.810* *E*:199, >>> 4: *No value for argument 'phase' in function call* >>> (*no-value-for-parameter*) >>> >>> >>> Using pylint 1.8, released 4 days ago. >>> >>> >>> >>>> >>>>> *00:07:29.210* ************* Module >>>>> vdsm.network.netlink.monitor*00:07:29.212* *E*:172,58: *Instance of >>>>> 'closing' has no 'poll' member* (*no-member*) >>>>> >>>>> >>>>> >>>>>> >>>>>> >>>>>> On Tue, Dec 12, 2017 at 2:09 AM, Nir Soffer <[email protected]> >>>>>> wrote: >>>>>> >>>>>>> I'm trying to upgrade pylint to latest so we can enjoy latest fixes >>>>>>> like this: >>>>>>> https://github.com/PyCQA/pylint/issues/1736 >>>>>>> >>>>>>> Now we have some new errors, please check. >>>>>>> >>>>>>> ************* Module vdsm.clientIF*00:06:53.857* *E*:588,16: *Possible >>>>>>> unbalanced tuple unpacking with sequence: left side has 2 label(s), >>>>>>> right side has 0 value(s)* (*unbalanced-tuple-unpacking*) >>>>>>> >>>>>>> >>>>>>> 587 if eventid == libvirt.VIR_DOMAIN_EVENT_ID_LIFECYCLE: >>>>>>> 588 event, detail = args[:-1] >>>>>>> 589 v.onLibvirtLifecycleEvent(event, detail, None) >>>>>>> >>>>>>> >>>>>>> Code is indeed incorrect, should be: >>>>>>> >>>>>>> event, detail = args[:2] >>>>>>> >>>>>>> >>>>>>> *00:06:53.859* *E*:593,16: *Possible unbalanced tuple unpacking with >>>>>>> sequence: left side has 1 label(s), right side has 0 value(s)* >>>>>>> (*unbalanced-tuple-unpacking*)*00:06:53.861* *E*:596,16: *Possible >>>>>>> unbalanced tuple unpacking with sequence: left side has 4 label(s), >>>>>>> right side has 0 value(s)* (*unbalanced-tuple-unpacking*)*00:06:53.863* >>>>>>> *E*:599,16: *Possible unbalanced tuple unpacking with sequence: left >>>>>>> side has 5 label(s), right side has 0 value(s)* >>>>>>> (*unbalanced-tuple-unpacking*)*00:06:53.867* *E*:610,16: *Possible >>>>>>> unbalanced tuple unpacking with sequence: left side has 1 label(s), >>>>>>> right side has 0 value(s)* (*unbalanced-tuple-unpacking*)*00:06:53.869* >>>>>>> *E*:615,16: *Possible unbalanced tuple unpacking with sequence: left >>>>>>> side has 1 label(s), right side has 0 value(s)* >>>>>>> (*unbalanced-tuple-unpacking*)*00:06:53.872* *E*:618,16: *Possible >>>>>>> unbalanced tuple unpacking with sequence: left side has 4 label(s), >>>>>>> right side has 0 value(s)* (*unbalanced-tuple-unpacking*)*00:06:53.873* >>>>>>> ************* Module vdsm.v2v*00:06:53.874* *E*:1368,27: *Instance of >>>>>>> 'closing' has no 'read' member* (*no-member*)*00:06:53.876* >>>>>>> ************* Module vdsm.tool.configurator*00:06:53.878* *E*:118,12: >>>>>>> *No value for argument 'action' in function call* >>>>>>> (*no-value-for-parameter*)*00:06:53.880* *E*:158,12: *No value for >>>>>>> argument 'action' in function call* >>>>>>> (*no-value-for-parameter*)*00:06:53.881* *E*:193,12: *No value for >>>>>>> argument 'action' in function call* >>>>>>> (*no-value-for-parameter*)*00:06:53.883* *E*:215,12: *No value for >>>>>>> argument 'action' in function call* >>>>>>> (*no-value-for-parameter*)*00:06:53.885* ************* Module >>>>>>> vdsm.virt.vm_migrate_hook*00:06:53.886* *E*:199, 4: *No value for >>>>>>> argument 'domain' in function call* >>>>>>> (*no-value-for-parameter*)*00:06:53.888* *E*:199, 4: *No value for >>>>>>> argument 'event' in function call* >>>>>>> (*no-value-for-parameter*)*00:06:53.890* *E*:199, 4: *No value for >>>>>>> argument 'phase' in function call* >>>>>>> (*no-value-for-parameter*)*00:06:53.892* ************* Module >>>>>>> vdsm.network.netlink.monitor*00:06:53.893* *E*:172,58: *Instance of >>>>>>> 'closing' has no 'poll' member* (*no-member*) >>>>>>> >>>>>>> >>>>>>> _______________________________________________ >>>>>>> Devel mailing list >>>>>>> [email protected] >>>>>>> http://lists.ovirt.org/mailman/listinfo/devel >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> >>>>>> IRIT GOIHMAN >>>>>> >>>>>> SOFTWARE ENGINEER >>>>>> >>>>>> EMEA VIRTUALIZATION R&D >>>>>> >>>>>> Red Hat EMEA <https://www.redhat.com/> >>>>>> >>>>>> <https://red.ht/sig> >>>>>> TRIED. TESTED. TRUSTED. <https://redhat.com/trusted> >>>>>> @redhatnews <https://twitter.com/redhatnews> Red Hat >>>>>> <https://www.linkedin.com/company/red-hat> Red Hat >>>>>> <https://www.facebook.com/RedHatInc> >>>>>> >>>>> >
_______________________________________________ Devel mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/devel
