The patch was reported to cause 3 different issues but I cannot say for sure that the notifier error was actually one of them. I can say that all issues from master and 4.2 were cleared once the fix from Shmuel was merged and tested in cq.
On Wed, Mar 21, 2018 at 10:28 AM, Michal Skrivanek < [email protected]> wrote: > > > On 20 Mar 2018, at 10:33, Yaniv Kaul <[email protected]> wrote: > > > > On Tue, Mar 20, 2018 at 9:49 AM, Michal Skrivanek < > [email protected]> wrote: > >> I’m not sure what is that test actually testing, if it depends on the >> previous host action which fails but is not verified it still may be >> relevant to Shmuel’s patch >> adding author of the test and the notifier owner >> > > It is checking that the notifier works - which sends SNMP notifications on > our events. I happen to picked an event which is VDC_STOP - which happens > when the engine is restarted - which happens earlier, when we configure it. > > > not sure if that’s reliable then. Doesn’t look related to that patch at > all. Dafna, does the same error reproduce all the time after that exact > patch? > > Y. > > >> >> On 19 Mar 2018, at 13:06, Dafna Ron <[email protected]> wrote: >> >> Hi, >> >> We had a failure in test 002_bootstrap.verify_notifier. >> I can't see anything wrong with the notifier and I don't think it should >> be related to the change that was reported. >> >> the test itself is looking for vdc_stop in messages which I do not indeed >> see but I am not sure what is the cause and how the reported change related >> to the failure. >> >> Can you please take a look? >> >> >> >> *Link and headline of suspected patches: * >> >> >> >> >> >> >> *core: USB in osinfo configuration depends on chipset - >> https://gerrit.ovirt.org/#/c/88777/ >> <https://gerrit.ovirt.org/#/c/88777/>Link to >> Job:http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/6429/ >> <http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/6429/>Link >> to all >> logs:http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/6429/artifacts >> <http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/6429/artifacts>(Relevant) >> error snippet from the log: <error>* >> *this is the error from *the api: >> >> >> Error Message >> >> Failed grep for VDC_STOP with code 1. Output: >> -------------------- >> begin captured logging << -------------------- >> lago.ssh: DEBUG: start task:f1231b27-f796-406c-8618-17b0868725bc:Get ssh >> client for lago-basic-suite-master-engine: >> lago.ssh: DEBUG: end task:f1231b27-f796-406c-8618-17b0868725bc:Get ssh >> client for lago-basic-suite-master-engine: >> lago.ssh: DEBUG: Running 1cce7c0c on lago-basic-suite-master-engine: grep >> VDC_STOP /var/log/messages >> lago.ssh: DEBUG: Command 1cce7c0c on lago-basic-suite-master-engine returned >> with 1 >> --------------------- >> end captured logging << --------------------- >> >> Stacktrace >> >> File "/usr/lib64/python2.7/unittest/case.py", line 369, in run >> testMethod() >> File "/usr/lib/python2.7/site-packages/nose/case.py", line 197, in runTest >> self.test(*self.arg) >> File "/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line 129, in >> wrapped_test >> test() >> File "/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line 59, in >> wrapper >> return func(get_test_prefix(), *args, **kwargs) >> File >> "/home/jenkins/workspace/ovirt-master_change-queue-tester/ovirt-system-tests/basic-suite-master/test-scenarios/002_bootstrap.py", >> line 1456, in verify_notifier >> 'Failed grep for VDC_STOP with code {0}. Output: >> {1}'.format(result.code, result.out) >> File "/usr/lib/python2.7/site-packages/nose/tools/trivial.py", line 29, in >> eq_ >> raise AssertionError(msg or "%r != %r" % (a, b)) >> 'Failed grep for VDC_STOP with code 1. Output: \n-------------------- >> >> begin captured logging << --------------------\nlago.ssh: DEBUG: start >> task:f1231b27-f796-406c-8618-17b0868725bc:Get ssh client for >> lago-basic-suite-master-engine:\nlago.ssh: DEBUG: end >> task:f1231b27-f796-406c-8618-17b0868725bc:Get ssh client for >> lago-basic-suite-master-engine:\nlago.ssh: DEBUG: Running 1cce7c0c on >> lago-basic-suite-master-engine: grep VDC_STOP /var/log/messages\nlago.ssh: >> DEBUG: Command 1cce7c0c on lago-basic-suite-master-engine returned with >> 1\n--------------------- >> end captured logging << ---------------------' >> >> >> *</error>* >> _______________________________________________ >> Devel mailing list >> [email protected] >> http://lists.ovirt.org/mailman/listinfo/devel >> >> >> > >
_______________________________________________ Devel mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/devel
