On Wed, Sep 19, 2018 at 1:57 PM Germano Veit Michel <[email protected]> wrote:
> Hi, > > I'm struggling with a check-patch failing. This is the error (I think): > > [7;33m************* Module vdsm.tool.update_volume [0m > [1;31mE [0m: 87,16: [1;31mInstance of '_Client' has no 'Host' member [0m ( > [1;31mno-member [0m) > [1;31mE [0m:101,23: [1;31mInstance of '_Client' has no 'StoragePool' > member [0m ( [1;31mno-member [0m) > > The way I understand it, the error above from [1] means that the check > patch fails because the cli object does not contain Host or StoragePool. > However, from reading the code it seems the Host and StoragePool members > are created at runtime by parsing the API schema. So static checking for > [2] and [3] fails. > > I see some other tools doing similar things (i,e. dump_volume_chains), but > I can't find anything specific done to prevent it. Or am I missing > something? > > Any idea on how to solve this? > > [1] > https://jenkins.ovirt.org/job/vdsm_master_check-patch-el7-x86_64/25017/artifact/exported-artifacts/mock_logs/script/stdout_stderr.log > [2] > https://gerrit.ovirt.org/gitweb?p=vdsm.git;f=lib/vdsm/tool/update_volume.py;hb=refs/changes/05/94105/9#l193 > [3] > https://gerrit.ovirt.org/gitweb?p=vdsm.git;f=lib/vdsm/tool/update_volume.py;hb=refs/changes/05/94105/9#l87 > > > Thanks! > Germano > Update I added "pylint: disable=no-member" as I found on some other vdsm files and now those member errors are gone. But check_patch is apparently still returning 2, can't figure out why. Any ideas? https://jenkins.ovirt.org/job/vdsm_master_check-patch-el7-x86_64/25088/ https://gerrit.ovirt.org/#/c/94105/
_______________________________________________ Devel mailing list -- [email protected] To unsubscribe send an email to [email protected] Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/[email protected]/message/5ANNJEWAWVTOQ6PUWF3P7GLDRHN6NRRW/
