On Mon, Mar 25, 2019 at 2:59 PM Dan Kenigsberg <[email protected]> wrote:
> On Mon, Mar 25, 2019 at 2:58 PM Eyal Edri <[email protected]> wrote: > > > > > > > > On Mon, Mar 25, 2019 at 2:42 PM Dan Kenigsberg <[email protected]> > wrote: > >> > >> On Mon, Mar 25, 2019 at 2:14 PM Eyal Edri <[email protected]> wrote: > >> > > >> > > >> > > >> > On Mon, Mar 25, 2019 at 2:11 PM Dan Kenigsberg <[email protected]> > wrote: > >> >> > >> >> On Mon, Mar 25, 2019 at 12:12 PM Ales Musil <[email protected]> > wrote: > >> >> > > >> >> > Hi, > >> >> > > >> >> > I am not sure who is currently maintainer for the upgrade suite, > but please take a look at [1]. > >> >> > This patch is testing the engine upgrade issue with database vm_id > and vmt_id in interface table [2]. > >> >> > And at the same time serves as opening patch to put more > sophisticated tests into upgrade suite. > >> >> > > >> >> > Thank you. > >> >> > Regards, > >> >> > Ales > >> >> > > >> >> > [1] https://gerrit.ovirt.org/c/98656/ > >> >> > [2] https://bugzilla.redhat.com/show_bug.cgi?id=1547038 > >> >> > >> >> I've added everybody from > >> >> git log --format=fuller upgrade-from-release-suite-master |grep > >> >> '^Commit:' |sed 's/.*<//;s/>//' |sort|uniq > >> >> > >> > > >> > Historically the suite was added by OST team, and over the years also > contributed by infra/integration team. > >> > I believe the ownership lies somewhere between Infra/Integration > teams where upgrade errors can occur, depending on the error. > >> > >> > >> Can you suggest who should approve Ales's added logic? > > > > > > I suggest we'll give +2 rights to a maintainer from Infra/Integration > who can review and approve such patches going forward. > > If it just to merge, I can do it or Galit, but it needs to be someone > from development to review the code. > > Code has two +1s from ovirt developers. > merged. Though you might want to look into backporting to other upgrade suites for 4.2/4.3 -- Eyal edri MANAGER RHV/CNV DevOps EMEA VIRTUALIZATION R&D Red Hat EMEA <https://www.redhat.com/> <https://red.ht/sig> TRIED. TESTED. TRUSTED. <https://redhat.com/trusted> phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
_______________________________________________ Devel mailing list -- [email protected] To unsubscribe send an email to [email protected] Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/[email protected]/message/IHXSI3MLLNURXCAVPYXPNDE3D2IN5ZFC/
