On 10/11/19 10:21 AM, Marcin Sobczyk wrote:


On 10/11/19 10:07 AM, Francesco Romani wrote:
On 10/10/19 10:42 PM, Nir Soffer wrote:
I added centos-8 docker image:
https://hub.docker.com/r/ovirtorg/vdsm-test-centos-8

And centos-8 build in Travis:
https://travis-ci.org/nirs/vdsm/jobs/596270609

After fixing 22 tests trying to run /usr/bin/python2, we have
only 3 failing tests in lib-py36:

lib/hooks_test.py .....................x......F..............            [ 50%]
ssl_test.py ...........FF...               [100%]

Marcin already handled the ssl tests in:
https://gerrit.ovirt.org/c/103812/

I'm not sue why the hook test fail.


I *guess* incompatible pickle format between python versions?

Nope, the pickling and unpickling is done with the same interpreter version. I already posted that the patch for the issue is here and the explanation is in the commit message (tldr it's about some environments using ascii locale):

https://gerrit.ovirt.org/#/c/102455/


Yep, seen the patch and LGTM

Thanks!


--
Francesco Romani
Senior SW Eng., Virtualization R&D
Red Hat
IRC: fromani github: @fromanirh

_______________________________________________
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/V7DVGA47AJ5ALLLTJSXZMLPFRB6XPZEY/

Reply via email to