On 10/15/19 2:12 PM, Kaustav Majumder wrote:
Hi,
There is no constants.py file but constants.py.in <http://constants.py.in> -> https://pastebin.com/ATLrmTuh
That would suggest that you didn't run 'make' - this is the step that generates files from '*.in' ones.


On Tue, Oct 15, 2019 at 5:40 PM Marcin Sobczyk <[email protected] <mailto:[email protected]>> wrote:



    On 10/15/19 1:44 PM, Kaustav Majumder wrote:
    Thanks , solved the tox issue but now pytlint is throwing errors.
    Mostly with vdsm.constants.I have lines of
    ```
    E: 98,40: Module 'vdsm.constants' has no 'VDSM_GROUP' member
    (no-member)
    ************* Module vdsm.gluster.api
    E:232,15: Module 'vdsm.constants' has no 'EXT_MOUNT' member
    (no-member)
    ************* Module vdsm.gluster.gfapi
    E:228,35: Module 'vdsm.constants' has no 'P_VDSM' member (no-member)
    E:259,35: Module 'vdsm.constants' has no 'P_VDSM' member (no-member)
    ************* Module vdsm.supervdsm_api.udev
    ```
    for all places wherever vdsm.constants is required. Any change I
    am unaware of.
    Can you please pastebin the contents of your
    'lib/vdsm/common/constants.py' file?


    Full log here : https://pastebin.com/fb77r7Hj


    On Tue, Oct 15, 2019 at 1:17 PM Milan Zamazal
    <[email protected] <mailto:[email protected]>> wrote:

        Marcin Sobczyk <[email protected]
        <mailto:[email protected]>> writes:

        > Hi,
        >
        > On 10/14/19 3:06 PM, Kaustav Majumder wrote:
        >>
        >> Hi,
        >> I am having an issue running make check on vdsm master.
        >>
        >> `
        >> if [ -n "$NOSE_WITH_COVERAGE" ]; then \
        >>         mv .coverage .coverage-nose-py27; \
        >> fi
        >> Traceback (most recent call last):
        >>   File "../tests/testrunner.py", line 70, in <module>
        >>     from vdsm import constants
        >>   File
        "/home/kmajumde/work/git/vdsm/lib/vdsm/constants.py", line
        >> 29, in <module>
        >>     from vdsm.common.constants import *  # NOQA: F401, F403
        >> `
        >> Am I missing something? Do I need to run tests differently?
        > did you run plane 'make' before 'make check'?

        Wouldn't it be worth to fix the missing dependency? We hit
        this issue
        often.

        Even if we made `check' simply depend on `all', it would be
        fine IMO,
        since the running time of `all' is negligible to the running
        time of
        `check'.

        >> Thanks,
        >>
        >> Kaustav Majumder
        >>
        >>
        >> _______________________________________________
        >> Devel mailing list -- [email protected] <mailto:[email protected]>
        >> To unsubscribe send an email to [email protected]
        <mailto:[email protected]>
        >> Privacy Statement: https://www.ovirt.org/site/privacy-policy/
        >> oVirt Code of Conduct:
        https://www.ovirt.org/community/about/community-guidelines/
        >> List Archives:
        >>
        
https://lists.ovirt.org/archives/list/[email protected]/message/MTWRVTRJ5DLDVOWHW6RZWBLMETZ3NYCM/
        >
        > _______________________________________________
        > Devel mailing list -- [email protected] <mailto:[email protected]>
        > To unsubscribe send an email to [email protected]
        <mailto:[email protected]>
        > Privacy Statement: https://www.ovirt.org/site/privacy-policy/
        > oVirt Code of Conduct:
        https://www.ovirt.org/community/about/community-guidelines/
        > List Archives:
        >
        
https://lists.ovirt.org/archives/list/[email protected]/message/BHZSO3MJH6KT6QIDHM7S5QFIDPF473UE/
        _______________________________________________
        Devel mailing list -- [email protected] <mailto:[email protected]>
        To unsubscribe send an email to [email protected]
        <mailto:[email protected]>
        Privacy Statement: https://www.ovirt.org/site/privacy-policy/
        oVirt Code of Conduct:
        https://www.ovirt.org/community/about/community-guidelines/
        List Archives:
        
https://lists.ovirt.org/archives/list/[email protected]/message/7BJS3M6EVE7HQFDEJWVBAX3F4OP4YU5M/



--
    Thanks,

    Kaustav Majumder




--

Thanks,

Kaustav Majumder


_______________________________________________
Devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/[email protected]/message/EJPU4IWOC3N4ENSRQMATTK6DGCOQCNHI/

Reply via email to