Hi all, the notifications handling is a bit tricky, but it is not possible for the test just to ignore them since they cover the action buttons and the test cannot click the buttons Yes, we can get rid of them by clicking "Do not disturb" or we can simply wait until they disappear and the action button is visible again. But I'd prefer the notifications to be part of the workflow because that is something a real user does so I'd give it a try.
Anyway, I believe that these problems with the notifications in the OST UI tests only reflect the problem the real users have - namely that the notifications cover the action buttons.The following patch by Radek should solve it - the notifications will be displayed at the bottom right corner so they would not cover the action buttons. https://gerrit.ovirt.org/#/c/107710/ Regards, Lucia On Mon, Mar 23, 2020 at 9:34 AM Radoslaw Szwajkowski <[email protected]> wrote: > Hi guys, > if closing notification was proven to be unstable then I would rather > remove it from the suite and concentrate on the happy path. > Of course I assume we care only about jenkins - if we want to make the > tests run locally on every possible browser/hardware combination then we > might need to remove even more features. > > best regards, > Radek > > On Sat, Mar 21, 2020 at 8:26 PM Michal Skrivanek < > [email protected]> wrote: > >> >> >> On 20 Mar 2020, at 10:13, Lucia Jelinkova <[email protected]> wrote: >> >> Hi all, >> >> the patch that should improve notifications handling in the UI test has >> been merged. If you see more issues, please let me know. >> >> >> Hi Lucia, >> unfortunately I still see issues. It still doesn’t close the notification >> properly and in my case fails to click on "Power Off” in chrome. >> Test is clicking to 1222, 153. Maybe just move it 20 pixels to the left >> and that should do the job… >> >> Thanks, >> michal >> >> >> Regards, >> >> Lucia >> >> On Wed, Mar 18, 2020 at 2:38 PM Lucia Jelinkova <[email protected]> >> wrote: >> >>> Thank you Marcin, >>> >>> I'll post a patch for that. >>> >>> Lucia >>> >>> On Wed, Mar 18, 2020 at 2:24 PM Marcin Sobczyk <[email protected]> >>> wrote: >>> >>>> Hi, >>>> >>>> On 3/16/20 8:59 AM, Michal Skrivanek wrote: >>>> >>>> >>>> >>>> On 16 Mar 2020, at 08:20, Dominik Holler <[email protected]> wrote: >>>> >>>> Hello Lucia, >>>> I am unsure if the change queue is happy. Also the changes I merged >>>> might be a problem, but looks like >>>> 100_basic_ui_sanity.virtual_machines is still blocking in >>>> https://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/21208/ >>>> >>>> Do you have an idea how to fix this? >>>> >>>> >>>> manual is running just fine. >>>> log doesn’t tell which OST commit it is running so we can’t tell Im >>>> afraid… >>>> >>>> >>>> Thanks >>>> Dominik >>>> >>>> >>>> On Fri, Mar 13, 2020 at 10:21 AM Lucia Jelinkova <[email protected]> >>>> wrote: >>>> >>>>> Hello, >>>>> >>>>> the notification was not closed properly in the test. The fix was >>>>> merged this morning. Please let me know if you see any other issues with >>>>> OST UI tests. >>>>> >>>> I've experienced this again today while trying to run gating jobs for >>>> my OST patches: >>>> >>>> https://jenkins.ovirt.org/job/ovirt-system-tests_gate/446 >>>> >>>> >>>>> Regards, >>>>> >>>>> Lucia >>>>> >>>>> On Fri, Mar 13, 2020 at 7:53 AM Dominik Holler <[email protected]> >>>>> wrote: >>>>> >>>>>> Hello, >>>>>> 100_basic_ui_sanity.virtual_machines seems to fail on current master. >>>>>> Any ideas why? >>>>>> >>>>>> >>>>>> Please fine more details in >>>>>> >>>>>> https://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/21197/testReport/junit/(root)/100_basic_ui_sanity/virtual_machines/ >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> Devel mailing list -- [email protected] >>>>>> To unsubscribe send an email to [email protected] >>>>>> Privacy Statement: https://www.ovirt.org/privacy-policy.html >>>>>> oVirt Code of Conduct: >>>>>> https://www.ovirt.org/community/about/community-guidelines/ >>>>>> List Archives: >>>>>> https://lists.ovirt.org/archives/list/[email protected]/message/FT475CDDOEPDK4KVOZLJXF6JW5YERKEN/ >>>>>> >>>>> _______________________________________________ >>>> Devel mailing list -- [email protected] >>>> To unsubscribe send an email to [email protected] >>>> Privacy Statement: https://www.ovirt.org/privacy-policy.html >>>> oVirt Code of Conduct: >>>> https://www.ovirt.org/community/about/community-guidelines/ >>>> List Archives: >>>> https://lists.ovirt.org/archives/list/[email protected]/message/SSUP6XTRKOZB3AG62OJTT3QVUOGPTHNS/ >>>> >>>> >>>> >>>> _______________________________________________ >>>> Devel mailing list -- [email protected] >>>> To unsubscribe send an email to [email protected] >>>> Privacy Statement: https://www.ovirt.org/privacy-policy.html >>>> oVirt Code of Conduct: >>>> https://www.ovirt.org/community/about/community-guidelines/ >>>> List Archives: >>>> https://lists.ovirt.org/archives/list/[email protected]/message/5HDJ2FPC4LW27A46VEQZUDOA6D5H6MRQ/ >>>> >>>> >>>> >>
_______________________________________________ Devel mailing list -- [email protected] To unsubscribe send an email to [email protected] Privacy Statement: https://www.ovirt.org/privacy-policy.html oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/[email protected]/message/GZDSHGA6MSTROR4QBYMHRNPO6JFQNX2Y/
