> > I'll, but need to look more into it, replacing $(PREFIX) with
> > $(SYSCONF_DIR)
> > doesn't seem to work as SYSCONF_DIR=$(PREFIX)/etc (see https://github.com/
> > oVirt/ovirt-engine/blob/master/Makefile#L41
> > <https://github.com/oVirt/ovirt-engine/blob/master/Makefile#L41>), so we
> > will end up again with /
> > usr/etc. We will probably have to do it as VMCONSOLE_* variable - hardcode
> > config file and define new just install-dev environment (and do the proper
> > testing before merge)
> 
> No. SYSCONF_DIR=$(PREFIX)/etc allow you to set PREFIX for developer work.

isn't it overwritten here:
https://github.com/oVirt/ovirt-engine/blob/master/Makefile#L37
?

I posted https://gerrit.ovirt.org//c/108672/ which does it in the same way as 
ovirt-vmconsole, but if you prefer using SYSCONFIG_DIR and it work in all 
cases, no problem to change it this way

> But then in spec file it's overridden:
> SYSCONF_DIR=%{_sysconfdir}
> $ rpm --eval "%{_sysconfdir}"
> /etc

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/privacy-policy.html
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/CXYYQNFYIST2NRARPPH345UVTB5G2UL7/

Reply via email to