On Tue, Jun 23, 2020 at 2:47 PM Yedidyah Bar David <[email protected]> wrote: > > On Tue, Jun 23, 2020 at 1:01 PM Yedidyah Bar David <[email protected]> wrote: > > > > On Tue, Jun 23, 2020 at 12:44 PM Dominik Holler <[email protected]> wrote: > > > > > > https://jenkins.ovirt.org/job/ovirt-system-tests_standard-check-patch/9863/artifact/check-patch.basic_suite_master.el7.x86_64/test_logs/basic-suite-master/post-098_ovirt_provider_ovn_pytest.py/lago-basic-suite-master-engine/_var_log/ovirt-provider-ovn.log > > > > > > says: > > > > > > SSLError(CertificateError("hostname 'oldenginename' doesn't match > > > 'engine'",),)) > > > > > > > > > Maybe the cert used by engine is still for hostname 'engine' ? > > > > Thanks, didn't notice this. I see this also on my own system, and > > restarting the provider fixed it. Will send a patch for this.
With this patch: https://gerrit.ovirt.org/109835 packaging: rename: Restart ovirt-provider-ovn It's passing: https://jenkins.ovirt.org/view/oVirt%20system%20tests/job/ovirt-system-tests_manual/6996/ log does not have the above error anymore: https://jenkins.ovirt.org/view/oVirt%20system%20tests/job/ovirt-system-tests_manual/6996/artifact/exported-artifacts/test_logs/basic-suite-master/post-100_basic_ui_sanity_pytest.py/lago-basic-suite-master-engine/_var_log/ovirt-provider-ovn.log It does have this after restart, not sure it's important: 2020-06-23 08:41:14,956 ovsdbapp.backend.ovs_idl.vlog ssl:127.0.0.1:6641: no response to inactivity probe after 5.01 seconds, disconnecting It also has some errors before that, probably because it was starting in parallel to the running rename. I guess I should stop it in the beginning, updating the patch now. Is this enough for verification? Anything else I should try? > > BTW, now checked and saw that the same error appears also in the job that did > succeed, so perhaps failure of current is due to some other issue: > > https://jenkins.ovirt.org/view/oVirt%20system%20tests/job/ovirt-system-tests_manual/6978/ > > https://jenkins.ovirt.org/view/oVirt%20system%20tests/job/ovirt-system-tests_manual/6978/artifact/exported-artifacts/test_logs/basic-suite-master/post-100_basic_ui_sanity_pytest.py/lago-basic-suite-master-engine/_var_log/ovirt-provider-ovn.log > > > > > > > > > On Tue, Jun 23, 2020 at 11:03 AM Yedidyah Bar David <[email protected]> > > > wrote: > > >> > > >> On Mon, Jun 22, 2020 at 11:07 AM Code Review <[email protected]> wrote: > > >> > > > >> > From Jenkins CI <[email protected]>: > > >> > > > >> > Jenkins CI has posted comments on this change. > > >> > > > >> > Change subject: basic-suite: Run rename right after engine-setup > > >> > ...................................................................... > > >> > > > >> > > > >> > Patch Set 3: > > >> > > > >> > Build Failed > > >> > > > >> > https://jenkins.ovirt.org/job/ovirt-system-tests_standard-check-patch/9863/ > > >> > : FAILURE > > >> > > >> This failed with: > > >> > > >> https://jenkins.ovirt.org/job/ovirt-system-tests_standard-check-patch/9863/testReport/junit/basic-suite-master.test-scenarios/098_ovirt_provider_ovn_pytest/Invoking_jobs___check_patch_basic_suite_master_el7_x86_64___test_use_ovn_provider/ > > >> > > >> prefix = <ovirtlago.prefix.OvirtPrefix object at 0x7fcdab3b1c50> > > >> api_v4 = <ovirtsdk4.Connection object at 0x7fcdaa85c9d0> > > >> > > >> @versioning.require_version(4, 2) > > >> def test_use_ovn_provider(prefix, api_v4): > > >> engine = api_v4.system_service() > > >> engine_ip = prefix.virt_env.engine_vm().ip() > > >> provider_id = > > >> network_utils_v4.get_default_ovn_provider_id(engine) > > >> > > >> > token_id = _get_auth_token(engine_ip) > > >> > > >> ../basic-suite-master/test-scenarios/098_ovirt_provider_ovn_pytest.py:444: > > >> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ > > >> _ _ _ _ > > >> > > >> engine_name = '192.168.201.4' > > >> > > >> def _get_auth_token(engine_name): > > >> response_json = _request_auth_token(engine_name) > > >> > token_id = response_json['access']['token']['id'] > > >> E KeyError: 'access' > > >> > > >> ../basic-suite-master/test-scenarios/098_ovirt_provider_ovn_pytest.py:105: > > >> KeyError > > >> > > >> Is there a chance that it's due to my patch? > > >> > > >> > > > >> > -- > > >> > To view, visit https://gerrit.ovirt.org/109734 > > >> > > >> This patch runs initial setup with FQDN 'oldenginename', then runs > > >> rename with fqdn 'engine'. > > >> > > >> Above check-patch ran with whatever that was in the repos at the time. > > >> I also ran it with the manual job, only basic-suite-master, and the > > >> CI-built results of my then-pending patches, and it passed. > > >> > > >> This was yesterday. I then merged all patches, and now rebased this > > >> (OST) patch, to test again, still did not finish: > > >> > > >> https://jenkins.ovirt.org/job/ovirt-system-tests_standard-check-patch/9894/ > > >> > > >> That said, even if it passes, I am still not completely ok with my > > >> patches. What needs to be done to comprehensively test OVN (with or > > >> without rename)? > > >> > > >> If network suite passes, is this enough? > > >> > > >> Thanks, > > >> -- > > >> Didi > > >> > > > > > > -- > > Didi > > > > -- > Didi -- Didi _______________________________________________ Devel mailing list -- [email protected] To unsubscribe send an email to [email protected] Privacy Statement: https://www.ovirt.org/privacy-policy.html oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/[email protected]/message/XTPX4MRZOF7NWIX5QGTA52ADYW5GPVIR/
