Seven years ago, in June 2013, Giuseppe Valarelli introduced tests/functional/networkTests.py in https://gerrit.ovirt.org/#/c/14840/. It held high aspirations: to provide a comprehensive functional test for Vdsm's network API, in order to ease development of new code and reduce chances of reintroducing old bugs.
390 commits later, Andrej Cernak removed the last lines of code from that file in https://gerrit.ovirt.org/#/c/109182/. In between, many many other developers contributed to the set of tests, and later dissipated its content to multiple pytest-driven test modules. tests/functional/networkTests.py was never an emblem of great software design; it makes me happy to see it gone. But it was very useful and its spirit lives on: API tests are now the rule of Vdsm development, not an exception. I'd like to thank all the people who made this possible. $ git log 1c5f15c9b~ -- tests/functional/networkTests.py|grep Author|sort|uniq -c|sort -nr 72 Author: Edward Haas <[email protected]> 58 Author: Ido Barkan <[email protected]> 46 Author: Ondřej Svoboda <[email protected]> 40 Author: Petr Horáček <[email protected]> 35 Author: Dan Kenigsberg <[email protected]> 34 Author: Antoni S. Puimedon <[email protected]> 24 Author: Bell Levin <[email protected]> 23 Author: Leon Goldberg <[email protected]> 18 Author: Giuseppe Vallarelli <[email protected]> 8 Author: Assaf Muller <[email protected]> 5 Author: Sveta Haas <[email protected]> 4 Author: Mark Wu <[email protected]> 3 Author: Nir Soffer <[email protected]> 2 Author: Yaniv Bronhaim <[email protected]> 2 Author: Sagi Shnaidman <[email protected]> 2 Author: Petr Sebek <[email protected]> 2 Author: Miguel Angel Ajo <[email protected]> 2 Author: Andrej Cernek <[email protected]> 1 Author: Viliam Serecun <[email protected]> 1 Author: Vered Volansky <[email protected]> 1 Author: Timothy Asir Jeyasingh <[email protected]> 1 Author: shlad <[email protected]> 1 Author: pkliczewski <[email protected]> 1 Author: Petr Benas <[email protected]> 1 Author: Marcin Sobczyk <[email protected]> 1 Author: Marcin Mirecki <[email protected]> 1 Author: Ilia Meerovich <[email protected]> 1 Author: Genadi Chereshnya <[email protected]> 1 Author: Dominik Holler <[email protected]> _______________________________________________ Devel mailing list -- [email protected] To unsubscribe send an email to [email protected] Privacy Statement: https://www.ovirt.org/privacy-policy.html oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/[email protected]/message/WWBTUKYHAB376PXPNERSEFSPLTWV4H2L/
