Hi Evgheni, I've noticed that the mails now received from Gerrit are general and not contains the person/mechanism that added the comment. For example, if a person adds a comment or add +1 the mail that receives is -
--------------------------------------- View Change <https://gerrit.ovirt.org/c/vdsm/+/112420> 1 comment: - File lib/vdsm/virt/backup.py: <https://gerrit.ovirt.org/c/vdsm/+/112420/2/lib/vdsm/virt/backup.py> - Patch Set #2, Line 216: <https://gerrit.ovirt.org/c/vdsm/+/112420/2/lib/vdsm/virt/backup.py@216> _remove_scratch_disks(vm, backup_id) This duplicate the logic. Maybe: if backup exists: stop backup remove scratch disks Checking for backup exists should handle all cases like vm is undefined, etc. To view, visit change 112420 <https://gerrit.ovirt.org/c/vdsm/+/112420>. To unsubscribe, or for help writing mail filters, visit settings <https://gerrit.ovirt.org/settings>. --------------------------------------- In the previous version, the message contains also the person that added that comment. Can we include it in the new version also? Thanks On Tue, 25 Aug 2020 at 02:59, Evgheni Dereveanchin <edere...@redhat.com> wrote: > Maintenance completed, Jenkins is up and running. > Both the core and plugins have been upgraded, OS updates have also been > applied. > > As always - if you see any issues please report them to Jira. > > On Tue, Aug 25, 2020 at 1:02 AM Evgheni Dereveanchin <edere...@redhat.com> > wrote: > >> Hi everyone, >> >> I'll be performing a planned Jenkins restart within the next hour. >> No new CI jobs will be scheduled during this maintenance period. >> I will inform you once it is back online. >> >> -- >> Regards, >> Evgheni Dereveanchin >> > > > -- > Regards, > Evgheni Dereveanchin > _______________________________________________ > Devel mailing list -- devel@ovirt.org > To unsubscribe send an email to devel-le...@ovirt.org > Privacy Statement: https://www.ovirt.org/privacy-policy.html > oVirt Code of Conduct: > https://www.ovirt.org/community/about/community-guidelines/ > List Archives: > https://lists.ovirt.org/archives/list/devel@ovirt.org/message/NCCNGWSGYVHPFPRDDUO5S4FAR5TMPDTN/ > -- Regards, Eyal Shenitzky
_______________________________________________ Devel mailing list -- devel@ovirt.org To unsubscribe send an email to devel-le...@ovirt.org Privacy Statement: https://www.ovirt.org/privacy-policy.html oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/BXW3UREUWBVEE7N3PSTOZJC7BHOEJBJF/
