Hi Joakim,
I suggest to keep it simple: In the case you copy files that are
basically empty as your example below or in the case you remove
everything except the function declarations (as probably in low-level
drivers as gpio.c and others) I would just remove the existing copyright
and authors and put in solely yourself (and/or your company). Only in
the case that you keep actual code I would leave the existing
copyrights/authors.
At least for me this sounds like the way to go, any other opinions?
Cheers,
Hauke
On 09.12.2014 15:49, Joakim Gebart wrote:
What is the correct procedure regarding author and copyright headers
when I write a new port, but base the file off another port?
For example:
I start by copying the cpu/stm32f1 directory, as a basis for my new port.
The CPUs share no code other than RIOT generic code, such as API
(function declarations etc.).
Looking at cpu/stm32f1/lpm_arch.c [1], it has the following copyright header:
/*
* Copyright (C) 2013 INRIA
* Copyright (C) 2014 Freie Universität Berlin
*
* This file is subject to the terms and conditions of the GNU Lesser General
* Public License v2.1. See the file LICENSE in the top level directory for more
* details.
*/
/**
* @ingroup cpu_stm32f1
* @{
*
* @file lpm_arch.c
* @brief Implementation of the kernel's lpm interface
*
* @author Alaeddine Weslati <[email protected]>
* @author Hauke Petersen <[email protected]>
*
* @}
*/
All the functions in this file contain a single line `/* TODO */`, so
this file is only a stub necessary for building the project.
If I then implement all the functionality for the lpm functionality,
should I then add myself/my company as author and copyright or do I
leave the FU berlin stuff? Should I both add myself and keep the old
copyright? Should I remove the old copyright? What about @author
lines?
My gut feeling is that the correct way (legally) for me to implement
my own lpm_arch.c is to add Copyright (C) Eistec AB as a new line
below (C) FU Berlin as well as adding an @author line to the file
Doxygen block. This means that this file would end up with three
copyright lines, and three authors, of whom only one knows anything
about the code it contains.
[1]: https://github.com/RIOT-OS/RIOT/blob/master/cpu/stm32f1/lpm_arch.c
Best regards,
Joakim Gebart
Managing Director
Eistec AB
Aurorum 1C
977 75 Luleå
Tel: +46(0)730-65 13 83
[email protected]
www.eistec.se
_______________________________________________
devel mailing list
[email protected]
http://lists.riot-os.org/mailman/listinfo/devel
_______________________________________________
devel mailing list
[email protected]
http://lists.riot-os.org/mailman/listinfo/devel
