Hi,
Here's the PR:
https://github.com/RIOT-OS/RIOT/pull/2503
Please discuss!
Cheers, Ludwig
On Fri, Feb 27, 2015 at 07:08:43AM +0100, Ludwig Ortmann wrote:
> Hi,
>
> Yes, we came to the same conclusion while driving to embedded world.
> I've got the implementation and API specification ready as well and will
> open a PR later.
>
> Cheers, Ludwig
>
> Am 27. Februar 2015 02:14:51 MEZ, schrieb Jozef Maslik
> <ma...@binarylemon.com>:
> >Hi,
> >
> >Yes compiler do not optimize (remove out) empty function defined as is
> >suggested.
> >But if RIOT does not want use macros, we can define empty function as
> >static inline function in header and then will be removed by
> >optimization.
> >
> >log_api.h
> >
> >#if MODULE_LOG
> >void log_info(...);
> >#else
> >static inline void log_info(...) {}
> >#endif
> >
> >
> >BTW. Hauke idea use modules is nice.
> >
> >Regards,
> >Jozef
> >
> >
> >
> >
> >
> >> On 23 Feb 2015, at 13:00, Martine Lenders <authmille...@gmail.com>
> >wrote:
> >>
> >> Hi,
> >>
> >> Am 23.02.2015 10:04 schrieb "Ludwig Ortmann"
> ><ludwig.ortm...@fu-berlin.de>:
> >> > are you suggesting macros are better than APIs + functions?
> >> > If so, please explain why and what better means ;)
> >>
> >> I was not sure if the compiler optimizes out empty functions, so I
> >assumed
> >>
> >> #define INFO(msg) (void)0;
> >>
> >> to be the better solution concerning code size.
> >>
> >> Regards,
> >> Martine
> >> _______________________________________________
> >> devel mailing list
> >> devel@riot-os.org
> >> http://lists.riot-os.org/mailman/listinfo/devel
> >
> >_______________________________________________
> >devel mailing list
> >devel@riot-os.org
> >http://lists.riot-os.org/mailman/listinfo/devel
>
> _______________________________________________
> devel mailing list
> devel@riot-os.org
> http://lists.riot-os.org/mailman/listinfo/devel
_______________________________________________
devel mailing list
devel@riot-os.org
http://lists.riot-os.org/mailman/listinfo/devel
