Hey guys,
I agree with Hauke on the LPM pull request from the thirdparty-repo. It is an interesting approach but the PR is based on ST's standard library and therefore would need to be completely rewritten.
I think RIOT is currently missing an implementation for the RTC periph low-level driver for the STM32F4 series or have I overlooked something? Probably that should be added first anyhow before thinking about including any kind of RTC functionality in the LPM-Interface.
Best,
Fabian
Gesendet: Montag, 23. März 2015 um 11:35 Uhr
Von: "Hauke Petersen" <hauke.peter...@fu-berlin.de>
An: "RIOT OS kernel developers" <de...@lists.stillroot.org>, "RIOT OS kernel developers" <devel@riot-os.org>
Betreff: Re: [riot-devel] Removing thirdparty repositories
Von: "Hauke Petersen" <hauke.peter...@fu-berlin.de>
An: "RIOT OS kernel developers" <de...@lists.stillroot.org>, "RIOT OS kernel developers" <devel@riot-os.org>
Betreff: Re: [riot-devel] Removing thirdparty repositories
Hi,
I think it's fine to close the repo. As for the PR's, the sleep mode one
is the only one containing an interesting feature. This we have already
partly implemented (lpm states, RTC). Also the implementation in that PR
does not fit into our architecture, so it would have to be hard
refactored anyhow... In the end, I am not really sure how much
functionality is in that PR that we have not already merged into master...
Cheers,
Hauke
On 23.03.2015 08:53, Peter Kietzmann wrote:
> Hi,
>
> no objections from my side but I agree with @gabart that the LPM stuff
> might be interesting. Maybe Fabian Nack (@fnack) can tell whether
> something can be taken out of this PR?
>
> Best,
> Peter
>
>
> Am 22.03.2015 um 06:58 schrieb Joakim Gebart:
>> I haven't looked too closely, but I think at least the ideas put
>> forward in https://github.com/RIOT-OS/thirdparty_cpu/pull/3 are
>> useful. The PRs are old so they probably won't work on the current
>> master but the LPM stuff is interesting.
>> On the thirdparty_boards repo I didn't find anything interesting.
>>
>> Best regards,
>> Joakim Gebart
>> www.eistec.se
>>
>>
>> On Sun, Mar 22, 2015 at 12:12 AM, Oleg Hahm <oliver.h...@inria.fr>
>> wrote:
>>> Dear rousing IoTlers,
>>>
>>> since we don't need the thirdparty repositories for CPUs and boards
>>> any more
>>> for quite some time, I think we should finally remove them. Any
>>> objections?
>>> Can anyone with some experience with the Cortex ports take a look at
>>> the PRs
>>> in these repos that are still open and see if they contain anything
>>> useful
>>> that might be applied to the current implementation in RIOT master?
>>>
>>> Cheers,
>>> Oleg
>>> --
>>> arrival order packet joke is critical to good a make
>>>
>>> _______________________________________________
>>> devel mailing list
>>> devel@riot-os.org
>>> http://lists.riot-os.org/mailman/listinfo/devel
>>>
>> _______________________________________________
>> devel mailing list
>> devel@riot-os.org
>> http://lists.riot-os.org/mailman/listinfo/devel
>
_______________________________________________
devel mailing list
de...@lists.stillroot.org
https://lists.stillroot.org/mailman/listinfo/devel
I think it's fine to close the repo. As for the PR's, the sleep mode one
is the only one containing an interesting feature. This we have already
partly implemented (lpm states, RTC). Also the implementation in that PR
does not fit into our architecture, so it would have to be hard
refactored anyhow... In the end, I am not really sure how much
functionality is in that PR that we have not already merged into master...
Cheers,
Hauke
On 23.03.2015 08:53, Peter Kietzmann wrote:
> Hi,
>
> no objections from my side but I agree with @gabart that the LPM stuff
> might be interesting. Maybe Fabian Nack (@fnack) can tell whether
> something can be taken out of this PR?
>
> Best,
> Peter
>
>
> Am 22.03.2015 um 06:58 schrieb Joakim Gebart:
>> I haven't looked too closely, but I think at least the ideas put
>> forward in https://github.com/RIOT-OS/thirdparty_cpu/pull/3 are
>> useful. The PRs are old so they probably won't work on the current
>> master but the LPM stuff is interesting.
>> On the thirdparty_boards repo I didn't find anything interesting.
>>
>> Best regards,
>> Joakim Gebart
>> www.eistec.se
>>
>>
>> On Sun, Mar 22, 2015 at 12:12 AM, Oleg Hahm <oliver.h...@inria.fr>
>> wrote:
>>> Dear rousing IoTlers,
>>>
>>> since we don't need the thirdparty repositories for CPUs and boards
>>> any more
>>> for quite some time, I think we should finally remove them. Any
>>> objections?
>>> Can anyone with some experience with the Cortex ports take a look at
>>> the PRs
>>> in these repos that are still open and see if they contain anything
>>> useful
>>> that might be applied to the current implementation in RIOT master?
>>>
>>> Cheers,
>>> Oleg
>>> --
>>> arrival order packet joke is critical to good a make
>>>
>>> _______________________________________________
>>> devel mailing list
>>> devel@riot-os.org
>>> http://lists.riot-os.org/mailman/listinfo/devel
>>>
>> _______________________________________________
>> devel mailing list
>> devel@riot-os.org
>> http://lists.riot-os.org/mailman/listinfo/devel
>
_______________________________________________
devel mailing list
de...@lists.stillroot.org
https://lists.stillroot.org/mailman/listinfo/devel
_______________________________________________ devel mailing list devel@riot-os.org https://lists.riot-os.org/mailman/listinfo/devel
