Hi, just to add my rational to the discussion: I don't like that I have to edit files to activate debugging messages (and potentially adding the change to my PR by accident). My PR eliminates - but does not prohibit (one can still add the `#define ENABLE_DEBUG (1)` before the debug.h include) - the need for that.
Cheers, Martine 2015-04-21 11:26 GMT+02:00 Kaspar Schleiser <[email protected]>: > Hey, > > On 04/21/15 10:14, Oleg Hahm wrote: > >> some time ago Martine proposed to move the `ENABLE_DEBUG` macro from file >> to >> module context [1]. Since this would effect the whole RIOT printf >> debugging, I >> would like to call on the mailing list if someone thinks that this would >> be a >> bad idea. >> > > I like that I can switch on debugging per file. Still you can easily use > "#define ENABLE_DEBUG MY_MODULE_DEBUG_FLAG" before including debug.h. So we > already have both options. Why change? > > Kaspar > _______________________________________________ > devel mailing list > [email protected] > https://lists.riot-os.org/mailman/listinfo/devel >
_______________________________________________ devel mailing list [email protected] https://lists.riot-os.org/mailman/listinfo/devel
