Dear reviewing IoTlers, looking at https://github.com/RIOT-OS/RIOT/pull/5758, I just realized that our convention to add squash commits while a PR is under review may need an amendment. If all commits that addresses a certain comment and are meant for squashing have a non-speaking commit message (see linked PR), then it gets more time-consuming for the reviewer to map a commit to a certain review-reaction. Hence, I would propose to somehow reference the addressed comment in the commit message. What do you think?
Cheers,
Oleg
--
printk(KERN_WARNING MYNAM ": (time to go bang on somebodies door)\n");
linux-2.6.6/drivers/message/fusion/mptctl.c
signature.asc
Description: PGP signature
_______________________________________________ devel mailing list [email protected] https://lists.riot-os.org/mailman/listinfo/devel
