Martine and I discussed this over a PR a few months ago. The outcome was
to update the Good Pull Request wiki page [1], which basically says what
has just been discussed on this thread. Good to spread the word and
share the link. :-)
Ken
[1]
https://github.com/RIOT-OS/RIOT/wiki/Guidelines-for-Creating-a-Good-Pull-Request
On 10/10/2018 03:31 AM, Joakim Nohlgård wrote:
+1 what Martine wrote.
(I was composing a similar message when you beat me to it)
/Joakim
Den ons 10 okt. 2018 08:51Martine Lenders <[email protected]
<mailto:[email protected]>> skrev:
Hi Pekka,
the 50 chars is just the warning bound. You can go up to 70 until
the commit message check fails on you. Longer will make GitHub
break the commit message in the webview with the dreaded […] ;-).
My usual approach is to boil down the summary to the bare minimum
within these constraints (even using just the module name instead
of the full path) and go into details in the following lines of
the commit message.
Regards,
Martine
Am Mi., 10. Okt. 2018 um 08:06 Uhr schrieb Nikander Pekka
<[email protected] <mailto:[email protected]>>:
[Refactoring the nRF520 mega-PR to follow the standards...]
I guess this has been bashed to death, but I am annoyed.
With long paths, the 50 characters limit on the first line
of the commit message makes it impossible to have any meaningful
explanation of what the commit actually does. Actually,
the limitation makes the commit messages unintelligible.
_Any_ change of increasing the limit to e.g. 72 characters?
--Pekka
_______________________________________________
devel mailing list
[email protected] <mailto:[email protected]>
https://lists.riot-os.org/mailman/listinfo/devel
_______________________________________________
devel mailing list
[email protected] <mailto:[email protected]>
https://lists.riot-os.org/mailman/listinfo/devel
_______________________________________________
devel mailing list
[email protected]
https://lists.riot-os.org/mailman/listinfo/devel
_______________________________________________
devel mailing list
[email protected]
https://lists.riot-os.org/mailman/listinfo/devel
