On 03/06/16 13:20, Mudit Jain wrote:
In the latest commit I have followed the FreeBSD port guidelines given libbsd.txt using the tools to port the code.

Sorry for being pedantic, but please follow the guidelines exactly:

"Only add lines. If your patch contains lines starting with a '-', then this is wrong. Subtract code by added `#ifndef __rtems__`. This makes merging easier
in the future.  For example:"

So, if you see red lines in your patches, then this is wrong.

Do not rename things in the modules unless absolutely necessary. Do not adjust header includes, instead fix the build system.

--
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.hu...@embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.

_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Reply via email to