Ok, the branch with only these four patches is here:
From: Christian Mauderer <l...@c-mauderer.de>
Sent: Saturday, August 12, 2017 17:05
To: Chris Johns; Sichen Zhao; Sichen Zhao; email@example.com
Cc: Christian Mauderer
Subject: Re: [PATCH v2 1/4] waf_generator: Copy headers if necessary.
Am 12.08.2017 um 05:57 schrieb Chris Johns:
> On 12/08/2017 13:30, Sichen Zhao wrote:
>>>> + for headers in header_build_copy_paths:
>>>> + target = os.path.join("build-include", headers)
>>>> + start_dir = bld.path.find_dir(headers)
>>>> + for header in start_dir.ant_glob(os.path.join("**/", headers)):
>>> Remove the '/':
>>> for header in start_dir.ant_glob(os.path.join("**", headers)):
>>> OK to push once fixed.
>> This already done in the PATCH v2 2/4.
>> - self.add(' for header in
>> start_dir.ant_glob(os.path.join("**/", headers)):')
>> + self.add(' for header in start_dir.ant_glob(headers):')
> Excellent. These patches look good. Christian let me know if you want me to
> do this?
> Thanks for your hard work.
yes, I think the patches are ready for merge. The little nitpick in the
os.path.join is something that is replaced in the second patch anyway
(like Sichen already mentioned) so I don't think it's worth the effort
to change it.
@Sichen: The patch 2/4 has been posted two times and the patch
containing the raw import is missing (most likely due to the size).
Could you post a link to a branch on your github repo with only these
four patches applied to the current master so Chris can make the merge?
devel mailing list