I tried to solve the empty get in the way shown in the patch , but it
doesn't seems to work, I'm getting the following error now

RTEMS Testing - Tester, 5 (1ed6e2e64090)
Traceback (most recent call last):
  File "/home/lunatic/development/rtems/rtems-tools/tester/rtems-test",
line 40, in <module>
    rt.test.run()
  File "/home/lunatic/development/rtems/rtems-tools/tester/rt/test.py",
line 303, in run
    bsp = config.load(bsp[1], opts)
  File "/home/lunatic/development/rtems/rtems-tools/tester/rt/config.py",
line 461, in load
    return opts.defaults['bsp']
  File
"/home/lunatic/development/rtems/rtems-tools/rtemstoolkit/macros.py", line
190, in __getitem__
    raise IndexError('key: %s' % (key))
IndexError: key: bsp


-- vijay

On 5 April 2018 at 11:51, Cillian O'Donnell <cpodonne...@gmail.com> wrote:

>
>
> On Wed, 4 Apr 2018, 11:18 Vijay Kumar Banerjee, <vijaykumar9...@gmail.com>
> wrote:
>
>> I got the rtems-test running
>>
>> I found that get_item_names(section, err) in configuration.py  was
>> returning an empty list to the
>> item_names in load(bsp,opts) for config.py this was giving out the error
>> mandatory item not found .
>>
>> I have attached the patch file .
>>
>> current status :
>> rtems-test is running without coverage
>>
>> running coverage gives the following error :
>>
>> RTEMS Testing - Tester, 5 (092c569e81ae)
>> Traceback (most recent call last):
>>   File "/home/lunatic/development/rtems/rtems-tools/tester/rtems-test",
>> line 40, in <module>
>>     rt.test.run()
>>   File "/home/lunatic/development/rtems/rtems-tools/tester/rt/test.py",
>> line 310, in run
>>     coverage = coverage_get_obj(opts, path_to_builddir[1])
>>   File "/home/lunatic/development/rtems/rtems-tools/tester/rt/test.py",
>> line 230, in coverage_get_obj
>>     coverage_obj = coverage.coverage_run(opts.defaults, path_to_builddir)
>>   File "/home/lunatic/development/rtems/rtems-tools/tester/rt/coverage.py",
>> line 335, in __init__
>>     self.report_format = self.config_map['report_format'][2]
>>
>
> This is back to the difference in cfg formats. It's looking for the last
> line here
>
> https://github.com/cillianodonnell/rtems-tools/blob/coverage/tester/rtems/
> testing/bsps/leon3-qemu.mc
>
> Which is now
>
> https://github.com/cillianodonnell/rtems-tools/
> blob/ini-update/tester/rtems/testing/bsps/leon3_qemu.ini
>
> It's trying to grab the 'html' text so it can trigger the right section of
> code in coverage.py
>
> It's something just to tell which format we want the report to output
>

Understood , I'll come to that after I manage to get the test running first
.

>
> TypeError: 'NoneType' object has no attribute '__getitem__'
>>
>>
>> Thanks
>>
>> -- vijay
>>
>> On 4 April 2018 at 11:16, Chris Johns <chr...@rtems.org> wrote:
>>
>>> On 04/04/2018 06:36, Vijay Kumar Banerjee wrote:
>>> > after pulling the ini-update branch from
>>> > https://github.com/cillianodonnell/rtems-tools/tree/ini-update
>>> >
>>>
>>> Any local changes?
>>>
>>> > I tried running the rtems-test with the following command
>>> >
>>> > $HOME/development/rtems/rtems-tools/tester/rtems-test
>>> > --rtems-tools=$HOME/development/rtems/5 --log=coverage_analysis.log
>>> > --rtems-bsp=leon3_qemu --rtems-builddir=$HOME/
>>> development/rtems/kernel/leon3
>>> > sparc-rtems5/c/leon3/testsuites/samples
>>> >
>>> > was getting the KeyError for 'coverage'
>>> >
>>>
>>> Please paste the command and output as it appears in the terminal?
>>>
>>> > current status :
>>> > the same command gives the error :
>>> > "mandatory item not found in bsp section : bsp,"
>>> > to make sure I didn't break something , I also tried running from a
>>> freshly
>>> > downloaded directory as well, it gives the same error.
>>>
>>> Did you try running the following command from the top of the source
>>> tree:
>>>
>>>  $ grep -r "mandatory item not found" *
>>>
>>> ?
>>>
>>> Chris
>>>
>>
>>
From 1ed6e2e6409041bd9288dab1923ad5a816299086 Mon Sep 17 00:00:00 2001
From: thelunatic <vijaykumar9...@gmail.com>
Date: Fri, 6 Apr 2018 02:11:04 +0530
Subject: [PATCH] setting raw=True in get_item_names

---
 rtemstoolkit/configuration.py | 2 +-
 tester/rt/config.py           | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/rtemstoolkit/configuration.py b/rtemstoolkit/configuration.py
index 6917a81..b742227 100644
--- a/rtemstoolkit/configuration.py
+++ b/rtemstoolkit/configuration.py
@@ -121,7 +121,7 @@ class configuration:
 
         try:
 
-            return [item[0] for item in self.config.items(section)]
+            return [item[0] for item in self.config.items(section,raw=True)]
         except:
             if err:
                 raise error.general('config: section "%s" not found' % (section))
diff --git a/tester/rt/config.py b/tester/rt/config.py
index 8c4b5b8..6cfd2f6 100644
--- a/tester/rt/config.py
+++ b/tester/rt/config.py
@@ -427,7 +427,7 @@ def load(bsp, opts):
                 if m not in item_names:
                     raise error.general('mandatory item not found in bsp section: %s ' % (m))
             opts.defaults.set_write_map(bsp, add = True)
-            for i in cfg.get_items(bsp,flatten = False):
+            for i in cfg.get_items(bsp,err=False,flatten = False):
                 opts.defaults[i[0]] = i[1]
 
             if not opts.defaults.set_read_map(bsp):
@@ -448,7 +448,7 @@ def load(bsp, opts):
                     cfg = configuration.configuration()
                     cfg.load(user_config)
                     if cfg.has_section(bsp):
-                        for i in cfg.get_items(bsp,flatten = False):
+                        for i in cfg.get_items(bsp,err=False,flatten = False):
                             opts.defaults[i[0]] = i[1]
 
             # Check for the required values.
-- 
2.14.3

_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Reply via email to