Hello Daniel,

On 21/12/2018 14:42, Daniel Hellstrom wrote:
Hi Sebastian,

Sorry for my very late response! I have reviewed the code but not executed it, it looks okay with me. I'm guessing it is also a positive thing to remove malloc for another approach to allocate memory when it comes to validation of the SW.

thanks for the review.

My next step is to move the grlib to bsps/shared/grlib so that it can be used for RISC-V BSPs.


Another aspect of the same subject could be to use the RTEMS memalign() instead of custom alignment within the driver for descriptor tables etc. The history there is that memalign() did not exist when writing most of the drivers.

Yes, this is also on my TODO list.


Merry Christmas and a happy new year!

Thanks, Merry Christmas and Happy New Year too.

--
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.hu...@embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.

_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Reply via email to